71% wordpress-flash-uploader

Code Review | Wordpress Flash Uploader

WordPress plugin Wordpress Flash Uploader scored71%from 54 tests.

About plugin

  • Plugin page: wordpress-flash-u...
  • Plugin version: 3.4.2
  • PHP version: 7.4.16
  • WordPress compatibility: 2.7-6.0.1
  • WordPress version: 6.3.1
  • First release: Apr 19, 2010
  • Latest release: Jan 18, 2023
  • Number of updates: 68
  • Update frequency: every 69.1 days
  • Top authors: mdempfle (100%)

Code review

54 tests

User reviews

4 reviews

Install metrics

1,000+ active /104,366 total downloads

Benchmarks

Plugin footprint 83% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | Verifying that this plugin installs correctly without errors
The plugin installed successfully, without throwing any errors or notices

Server metrics [RAM: ▲0.04MB] [CPU: ▲0.56ms] Passed 4 tests

This is a short check of server-side resources used by Wordpress Flash Uploader
Server-side resource usage in normal parameters
PageMemory (MB)CPU Time (ms)
Home /3.52 ▲0.0640.62 ▼6.24
Dashboard /wp-admin3.34 ▲0.0450.83 ▼0.64
Posts /wp-admin/edit.php3.46 ▲0.1051.60 ▲5.54
Add New Post /wp-admin/post-new.php5.92 ▲0.0495.85 ▲4.82
Media Library /wp-admin/upload.php3.27 ▲0.0439.25 ▲4.30

Server storage [IO: ▲1.32MB] [DB: ▲0.00MB] Passed 3 tests

A short overview of filesystem and database impact
The plugin installed successfully
Filesystem: 92 new files
Database: no new tables, 7 new options
New WordPress options
theysaidso_admin_options
widget_theysaidso_widget
db_upgraded
WFUAdminOptions
widget_recent-posts
widget_recent-comments
can_compress_scripts

Browser metrics Passed 4 tests

A check of browser resources used by Wordpress Flash Uploader
Normal browser usage
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,801 ▲4014.35 ▼0.381.92 ▼0.0641.15 ▼4.62
Dashboard /wp-admin2,207 ▲335.67 ▲0.1591.02 ▼13.2941.31 ▼0.87
Posts /wp-admin/edit.php2,112 ▲122.11 ▲0.1139.42 ▲3.4638.26 ▲1.86
Add New Post /wp-admin/post-new.php1,557 ▲3118.43 ▼4.83636.75 ▼58.8161.79 ▲4.12
Media Library /wp-admin/upload.php1,412 ▲154.16 ▲0.0595.51 ▼8.7244.28 ▼0.95
Sync Media Library /wp-admin/wordpress-flash-uploader.php?printSync=true260.420.0715.03
WP Flash Uploader /wp-admin/wordpress-flash-uploader.php260.420.106.46

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 75% from 4 tests

🔸 Tests weight: 35 | It is important to correctly uninstall your plugin, without leaving any traces
It is recommended to fix the following
  • The uninstall procedure has failed, leaving 7 options in the database
    • widget_theysaidso_widget
    • theysaidso_admin_options
    • can_compress_scripts
    • widget_recent-posts
    • WFUAdminOptions
    • db_upgraded
    • widget_recent-comments

Smoke tests 25% from 4 tests

Server-side errors Passed 1 test

🔹 Test weight: 20 | Just a short smoke test targeting errors on the server (in the Apache logs)
The smoke test was a success, however most plugin functionality was not tested

SRP 0% from 2 tests

🔹 Tests weight: 20 | A shallow check of the single-responsibility principle; PHP files should perform no action - including output of placeholder text - and trigger no errors when accessed directly
Please fix the following
  • 10× PHP files output text when accessed directly:
    • > /wp-content/plugins/wordpress-flash-uploader/tfu/tfu_zip.class.php
    • > /wp-content/plugins/wordpress-flash-uploader/tfu/tfu_upload.php
    • > /wp-content/plugins/wordpress-flash-uploader/tfu/my_tfu_config.php
    • > /wp-content/plugins/wordpress-flash-uploader/tfu/tfu_login.php
    • > /wp-content/plugins/wordpress-flash-uploader/tfu/tfu_config.php
    • > /wp-content/plugins/wordpress-flash-uploader/tfu/wfu_helper.php
    • > /wp-content/plugins/wordpress-flash-uploader/tfu/tfu_file.php
    • > /wp-content/plugins/wordpress-flash-uploader/tfu/tfu_session.php
    • > /wp-content/plugins/wordpress-flash-uploader/tfu/tfu_helper.php
    • > /wp-content/plugins/wordpress-flash-uploader/tfu/tfu_exifReader.php
  • 3× PHP files trigger server-side errors or warnings when accessed directly:
    • > PHP Warning
      Use of undefined constant WP_CONTENT_DIR - assumed 'WP_CONTENT_DIR' (this will throw an Error in a future version of PHP) in wp-content/plugins/wordpress-flash-uploader/wordpress-flash-uploader.php on line 15
    • > PHP Warning
      "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in wp-content/plugins/wordpress-flash-uploader/tfu/tfu_exifReader.php on line 1084
    • > PHP Fatal error
      Uncaught Error: Call to undefined function register_activation_hook() in wp-content/plugins/wordpress-flash-uploader/wordpress-flash-uploader.php:561

User-side errors 0% from 1 test

🔹 Test weight: 20 | A shallow check that no browser errors were triggered
Please fix the following browser errors
    • > GET request to /wp-admin/wordpress-flash-uploader.php?printSync=true
    • > Network (severe)
    wp-admin/wordpress-flash-uploader.php?printSync=true - Failed to load resource: the server responded with a status of 404 (Not Found)
    • > GET request to /wp-admin/wordpress-flash-uploader.php
    • > Network (severe)
    wp-admin/wordpress-flash-uploader.php - Failed to load resource: the server responded with a status of 404 (Not Found)

Optimizations

Plugin configuration 83% from 29 tests

readme.txt 81% from 16 tests

It's important to format your readme.txt file correctly as it is parsed for the public listing of your plugin
These attributes need your attention:
  • Tags: You are using too many tags: 13 tag instead of maximum 10
  • Screenshots: Please add images for these screenshots: #1 (The Wordpress Flash Uploader page where you can upload images), #2 (The Synch Media Library page where you can synchronize your upload folder with the Media Library), #3 (The Wordpress Flash Uploader included in the site directly with the shortapi/shortcode)
  • Donate link: Please fix this invalid url: "Please check the settings of Wordpress Flash Uploader"
You can look at the official readme.txt

wordpress-flash-uploader/wordpress-flash-uploader.php 85% from 13 tests

This is the main PHP file of "Wordpress Flash Uploader" version 3.4.2, providing information about the plugin in the header fields and serving as the principal entry point to the plugin's functions
You should first fix the following items:
  • Text Domain: The text domain name should consist of only dashes and lowercase characters
  • Description: Please keep the plugin description shorter than 140 characters (currently 601 characters long)

Code Analysis 97% from 3 tests

File types Passed 1 test

🔸 Test weight: 35 | This is a short overview of programming languages used in this plugin, detecting executable files
There were no executable files found in this plugin9,945 lines of code in 45 files:
LanguageFilesBlank linesComment linesLines of code
PHP147329576,035
XML282347343,813
CSS14092
JavaScript1044
HTML1001

PHP code 50% from 2 tests

A brief analysis of cyclomatic complexity and code structure for this plugin
These items need your attention
  • Method cyclomatic complexity has to be reduced to less than 100 (currently 169)
Cyclomatic complexity
Average complexity per logical line of code0.39
Average class complexity91.33
▷ Minimum class complexity6.00
▷ Maximum class complexity262.00
Average method complexity7.45
▷ Minimum method complexity1.00
▷ Maximum method complexity169.00
Code structure
Namespaces0
Interfaces0
Traits0
Classes6
▷ Abstract classes00.00%
▷ Concrete classes6100.00%
▷ Final classes00.00%
Methods84
▷ Static methods2732.14%
▷ Public methods84100.00%
▷ Protected methods00.00%
▷ Private methods00.00%
Functions109
▷ Named functions109100.00%
▷ Anonymous functions00.00%
Constants142
▷ Global constants142100.00%
▷ Class constants00.00%
▷ Public constants00.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

PNG files should be compressed to save space and minimize bandwidth usage
4 PNG files occupy 0.01MB with 0.00MB in potential savings
Potential savings
Compression of 4 random PNG files using pngquant
FileSize - originalSize - compressedSavings
img/logo.png5.11KB2.77KB▼ 45.75%
tfu/img/progressbar_back.png0.70KB1.16KB0.00%
tfu/img/progressbar.png1.21KB1.06KB▼ 12.78%
img/jfu_logo_32x32.png2.11KB1.80KB▼ 14.97%