71% softdiscover-db-file-manager

Code Review | File Manager, Code Editor, and Backup by Managefy

WordPress plugin File Manager, Code Editor, and Backup by Managefy scored 71% from 54 tests.

About plugin

  • Plugin page: softdiscover-db-f...
  • Plugin version: 1.3.2
  • PHP compatiblity: 5.3+
  • PHP version: 7.4.16
  • WordPress compatibility: 3.6-5.5
  • WordPress version: 6.3.1
  • First release: Aug 14, 2019
  • Latest release: Aug 17, 2020
  • Number of updates: 13
  • Update frequency: every 28.7 days
  • Top authors: softdiscover (100%)

Code review

54 tests

User reviews

1 review

Install metrics

80+ active / 2,091 total downloads

Benchmarks

Plugin footprint 83% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | It is important to correctly install your plugin, without throwing errors or notices
Installer ran successfully

Server metrics [RAM: ▲0.22MB] [CPU: ▼0.61ms] Passed 4 tests

This is a short check of server-side resources used by File Manager, Code Editor, and Backup by Managefy
No issues were detected with server-side resource usage
PageMemory (MB)CPU Time (ms)
Home /3.50 ▲0.0438.05 ▼4.44
Dashboard /wp-admin3.63 ▲0.3347.02 ▲1.98
Posts /wp-admin/edit.php3.68 ▲0.3247.27 ▼0.22
Add New Post /wp-admin/post-new.php6.15 ▲0.2686.21 ▲0.26
Media Library /wp-admin/upload.php3.49 ▲0.2636.15 ▲3.43
Backups /wp-admin/admin.php?page=flmbkp_page_backups3.8035.37
Settings /wp-admin/admin.php?page=flmbkp_page_settings3.7136.08
Database /wp-admin/admin.php?page=flmbkp_page_database3.7543.86
File Manager /wp-admin/admin.php?page=flmbkp_file_manager3.7636.66

Server storage [IO: ▲13.51MB] [DB: ▲0.00MB] Passed 3 tests

How much does this plugin use your filesystem and database?
There were no storage issued detected upon installing this plugin
Filesystem: 984 new files
Database: 1 new table, 7 new options
New tables
wp_flmbkp_backup
New WordPress options
can_compress_scripts
widget_recent-posts
flmbkpbuild_version
db_upgraded
theysaidso_admin_options
widget_theysaidso_widget
widget_recent-comments

Browser metrics Passed 4 tests

This is an overview of browser requirements for File Manager, Code Editor, and Backup by Managefy
Normal browser usage
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,834 ▲9913.25 ▼1.194.55 ▲2.8040.94 ▼1.64
Dashboard /wp-admin2,243 ▲715.82 ▼0.0998.05 ▼7.2178.73 ▲38.09
Posts /wp-admin/edit.php2,126 ▲371.99 ▼0.0335.08 ▼4.2133.64 ▼2.86
Add New Post /wp-admin/post-new.php1,551 ▲2323.03 ▲4.68690.95 ▲41.8850.57 ▼4.53
Media Library /wp-admin/upload.php1,422 ▲314.13 ▼0.1096.27 ▼4.1164.21 ▲20.93
Backups /wp-admin/admin.php?page=flmbkp_page_backups1,1232.1922.5479.11
Settings /wp-admin/admin.php?page=flmbkp_page_settings1,0042.1924.1137.72
Database /wp-admin/admin.php?page=flmbkp_page_database1,2901.8012.9130.45
File Manager /wp-admin/admin.php?page=flmbkp_file_manager4,9766.48234.30161.37

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 75% from 4 tests

🔸 Tests weight: 35 | Checking the uninstaller removed all traces of the plugin
It is recommended to fix the following
  • This plugin does not fully uninstall, leaving 6 options in the database
    • can_compress_scripts
    • db_upgraded
    • widget_theysaidso_widget
    • widget_recent-posts
    • theysaidso_admin_options
    • widget_recent-comments

Smoke tests 25% from 4 tests

Server-side errors 0% from 1 test

🔹 Test weight: 20 | A shallow check that no server-side errors were triggered
Almost there, just fix the following server-side errors
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=flmbkp_file_manager
    • > Deprecated in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/elFinder.class.php+2614
    Array and string offset access syntax with curly braces is deprecated

SRP 0% from 2 tests

🔹 Tests weight: 20 | SRP (Single-Responsibility Principle) - PHP files must act as libraries and never output text or perform any action when accessed directly in a browser
Please fix the following
  • 37× PHP files output non-empty strings when accessed directly via GET requests (only 10 are shown):
    • > /wp-content/plugins/softdiscover-db-file-manager/modules/settings/controllers/backend.php
    • > /wp-content/plugins/softdiscover-db-file-manager/modules/filemanager/controllers/backup.php
    • > /wp-content/plugins/softdiscover-db-file-manager/modules/database/views/backend/list_tables.php
    • > /wp-content/plugins/softdiscover-db-file-manager/classes/Pagination.php
    • > /wp-content/plugins/softdiscover-db-file-manager/modules/filemanager/views/backend/load_file_manager.php
    • > /wp-content/plugins/softdiscover-db-file-manager/classes/uiform-bootstrap.php
    • > /wp-content/plugins/softdiscover-db-file-manager/db-file-manager.php
    • > /wp-content/plugins/softdiscover-db-file-manager/modules/filemanager/views/backup/list_backups.php
    • > /wp-content/plugins/softdiscover-db-file-manager/views/layout_blank.php
    • > /wp-content/plugins/softdiscover-db-file-manager/modules/optbuilder/views/fields/parsehtml_button.php
  • 22× PHP files trigger server-side errors or warnings when accessed directly (only 10 are shown):
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderEditor' not found in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/editors/OnlineConvert/editor.php:3
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderVolumeDriver' not found in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/elFinderVolumeMySQL.class.php:8
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderPlugin' not found in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/plugins/AutoRotate/plugin.php:52
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderVolumeDriver' not found in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/elFinderVolumeOneDrive.class.php:10
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderVolumeDriver' not found in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/elFinderVolumeBox.class.php:10
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderVolumeDriver' not found in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/elFinderVolumeDropbox2.class.php:16
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderVolumeLocalFileSystem' not found in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/elFinderVolumeTrash.class.php:8
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderEditor' not found in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/editors/ZohoOffice/editor.php:3
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderPlugin' not found in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/plugins/Sanitizer/plugin.php:47
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderPlugin' not found in wp-content/plugins/softdiscover-db-file-manager/libraries/elfinder/php/plugins/Watermark/plugin.php:70

User-side errors Passed 1 test

🔹 Test weight: 20 | A shallow check that no browser errors were triggered
No browser issues were found

Optimizations

Plugin configuration 90% from 29 tests

readme.txt 94% from 16 tests

The readme.txt file is important because it is parsed by WordPress.org for the public listing of your plugin
These attributes need to be fixed:
  • Tags: You are using too many tags: 12 tag instead of maximum 10
You can look at the official readme.txt

softdiscover-db-file-manager/db-file-manager.php 85% from 13 tests

"File Manager, Code Editor, and Backup by Managefy" version 1.3.2's main PHP file describes plugin functionality and also serves as the entry point to any WordPress functionality
You should first fix the following items:
  • Description: Please keep the plugin description shorter than 140 characters (currently 201 characters long)
  • Main file name: It is recommended to name the main PHP file as the plugin slug ("softdiscover-db-file-manager.php" instead of "db-file-manager.php")

Code Analysis 95% from 3 tests

File types Passed 1 test

🔸 Test weight: 35 | Executable files are not allowed as they can serve as attack vectors
No dangerous file extensions were detected191,635 lines of code in 774 files:
LanguageFilesBlank linesComment linesLines of code
JavaScript39912,44912,715112,505
CSS1113,7881,26634,746
PHP703,97610,22221,240
HTML1362,641814,192
SVG259304,871
Sass1538351,796
LESS1434441,758
Markdown1650242
PO File199112217
JSON10046
SQL11022

PHP code 0% from 2 tests

An overview of cyclomatic complexity and code structure
The following items need your attention
  • Cyclomatic complexity of classes should be reduced to less than 1000 (currently 1,342)
  • Method cyclomatic complexity should be reduced to less than 100 (currently 149)
Cyclomatic complexity
Average complexity per logical line of code0.56
Average class complexity108.43
▷ Minimum class complexity1.00
▷ Maximum class complexity1,342.00
Average method complexity6.21
▷ Minimum method complexity1.00
▷ Maximum method complexity149.00
Code structure
Namespaces0
Interfaces1
Traits0
Classes46
▷ Abstract classes24.35%
▷ Concrete classes4495.65%
▷ Final classes12.27%
Methods1,010
▷ Static methods858.42%
▷ Public methods40440.00%
▷ Protected methods57356.73%
▷ Private methods333.27%
Functions4
▷ Named functions4100.00%
▷ Anonymous functions00.00%
Constants120
▷ Global constants3529.17%
▷ Class constants8570.83%
▷ Public constants85100.00%

Plugin size 50% from 2 tests

Image compression 50% from 2 tests

Often times overlooked, PNG files can occupy unnecessary space in your plugin
135 PNG files occupy 0.62MB with 0.26MB in potential savings
Potential savings
Compression of 5 random PNG files using pngquant
FileSize - originalSize - compressedSavings
assets/backend/img/uifm_field_recaptcha_prev_white_img.png4.97KB3.17KB▼ 36.26%
assets/common/css/jqueryui/1.11.4/themes/start/images/ui-bg_gloss-wave_50_6eac2c_500x100.png5.77KB2.11KB▼ 63.49%
libraries/elfinder/img/volume_icon_dropbox.png0.40KB0.53KB0.00%
assets/backend/image/express/express-banner-get-pro.png327.03KB108.94KB▼ 66.69%
assets/backend/image/about/logo.png6.26KB3.67KB▼ 41.47%