72% smokesignal

Code Review | SmokeSignal

WordPress plugin SmokeSignal scored72%from 54 tests.

About plugin

  • Plugin page: smokesignal
  • Plugin version: 1.2.7
  • PHP version: 7.4.16
  • WordPress compatibility: 3.0.1-4.8.1
  • WordPress version: 6.3.1
  • First release: Jan 11, 2015
  • Latest release: Sep 4, 2017
  • Number of updates: 40
  • Update frequency: every 24.3 days
  • Top authors: .dan (100%)

Code review

54 tests

User reviews

1 review

Install metrics

10+ active /1,379 total downloads

Benchmarks

Plugin footprint 83% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | It is important to correctly install your plugin, without throwing errors or notices
The plugin installed gracefully, with no errors

Server metrics [RAM: ▲0.12MB] [CPU: ▼2.72ms] Passed 4 tests

A check of server-side resources used by SmokeSignal
This plugin does not affect your website's performance
PageMemory (MB)CPU Time (ms)
Home /3.62 ▲0.1143.09 ▼1.15
Dashboard /wp-admin3.48 ▲0.1352.03 ▼0.62
Posts /wp-admin/edit.php3.59 ▲0.1956.15 ▲4.51
Add New Post /wp-admin/post-new.php6.06 ▲0.1389.85 ▼12.59
Media Library /wp-admin/upload.php3.40 ▲0.1339.51 ▲3.50
Groups /wp-admin/users.php?page=smokesignalgroup3.3752.42
SmokeSignal /wp-admin/options-general.php?page=my-setting-admin3.3534.09
Messages /wp-admin/users.php?page=smokesignal3.3837.36

Server storage [IO: ▲0.08MB] [DB: ▲0.00MB] Passed 3 tests

Input-output and database impact of this plugin
This plugin was installed successfully
Filesystem: 19 new files
Database: 3 new tables, 7 new options
New tables
wp_smokesignal_groups
wp_smokesignal_messages
wp_smokesignal_users_groups
New WordPress options
widget_recent-comments
widget_recent-posts
can_compress_scripts
theysaidso_admin_options
db_upgraded
widget_theysaidso_widget
smokesignal_db_version

Browser metrics Passed 4 tests

A check of browser resources used by SmokeSignal
Minimal impact on browser resources
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,898 ▲13713.79 ▼0.368.74 ▲7.1441.38 ▲2.62
Dashboard /wp-admin2,202 ▲245.56 ▼0.1188.21 ▼21.3542.96 ▲3.73
Posts /wp-admin/edit.php2,118 ▲152.23 ▲0.2334.36 ▼9.4735.39 ▼2.80
Add New Post /wp-admin/post-new.php1,543 ▲1722.94 ▼0.61672.25 ▲22.1337.43 ▼21.14
Media Library /wp-admin/upload.php1,417 ▲204.26 ▲0.09102.82 ▲1.2145.21 ▲3.60
Groups /wp-admin/users.php?page=smokesignalgroup8121.7727.1825.26
SmokeSignal /wp-admin/options-general.php?page=my-setting-admin8281.7426.3029.11
Messages /wp-admin/users.php?page=smokesignal8031.9130.2325.99

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 75% from 4 tests

🔸 Tests weight: 35 | Checking the uninstaller removed all traces of the plugin
These items require your attention
  • This plugin did not uninstall successfully, leaving 6 options in the database
    • can_compress_scripts
    • db_upgraded
    • widget_theysaidso_widget
    • widget_recent-comments
    • theysaidso_admin_options
    • widget_recent-posts

Smoke tests 25% from 4 tests

Server-side errors 0% from 1 test

🔹 Test weight: 20 | A smoke test targeting server-side errors
Smoke test failed, please fix the following
  • 34 occurences, only the last one shown
    • > GET request to /wp-admin/users.php?page=smokesignal
    • > Warning in wp-content/plugins/easy-age-verifier/lib/extras/wpApi.php+48
    file_get_contents(): php_network_getaddresses: getaddrinfo failed: Name or service not known
  • 34 occurences, only the last one shown
    • > GET request to /wp-admin/users.php?page=smokesignal
    • > Warning in wp-content/plugins/easy-age-verifier/lib/extras/wpApi.php+48
    file_get_contents(http://www.fillyourtaproom.com/wp-json/wp/v2/posts?per_page=10): failed to open stream: php_network_getaddresses: getaddrinfo failed: Name or service not known
  • 3 occurences, only the last one shown
    • > GET request to /wp-admin/options-general.php?page=my-setting-admin
    • > Notice in wp-content/plugins/smokesignal/options.php+142
    Trying to access array offset on value of type bool

SRP 0% from 2 tests

🔹 Tests weight: 20 | A shallow check of the single-responsibility principle; PHP files should perform no action - including output of placeholder text - and trigger no errors when accessed directly
Please fix the following items
  • 1× PHP files perform the action of outputting non-empty strings when accessed directly:
    • > /wp-content/plugins/smokesignal/views/single_message.php
  • 15× PHP files trigger server errors when accessed directly (only 10 are shown):
    • > PHP Fatal error
      Uncaught Error: Call to undefined function get_option() in wp-content/plugins/smokesignal/views/new.php:3
    • > PHP Warning
      Invalid argument supplied for foreach() in wp-content/plugins/smokesignal/views/single_message.php on line 3
    • > PHP Fatal error
      Uncaught Error: Call to undefined function is_admin() in wp-content/plugins/smokesignal/options.php:148
    • > PHP Fatal error
      Uncaught Error: Call to undefined function plugin_dir_url() in wp-content/plugins/smokesignal/smoke-signal.php:34
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_query_arg() in wp-content/plugins/smokesignal/views/groups/list.php:3
    • > PHP Fatal error
      Uncaught Error: Call to undefined function __() in wp-content/plugins/smokesignal/views/group.php:8
    • > PHP Notice
      Undefined variable: args in wp-content/plugins/smokesignal/views/single_message.php on line 54
    • > PHP Warning
      count(): Parameter must be an array or an object that implements Countable in wp-content/plugins/smokesignal/views/single_message.php on line 54
    • > PHP Fatal error
      Uncaught Error: Call to undefined function __() in wp-content/plugins/smokesignal/views/reply.php:3
    • > PHP Notice
      Trying to access array offset on value of type null in wp-content/plugins/smokesignal/views/single_message.php on line 3

User-side errors Passed 1 test

🔹 Test weight: 20 | This is a shallow check for browser errors
Everything seems fine, but this is not an exhaustive test

Optimizations

Plugin configuration 93% from 29 tests

readme.txt 94% from 16 tests

The readme.txt file is an important file in your plugin as it is parsed by WordPress.org to prepare the public listing of your plugin
These attributes need to be fixed:
  • Screenshots: These screenshots require images: #1 (You will get notification, when somebody writes you new message.), #2 (You can see the entire communication with one user on single page.)
Please take inspiration from this readme.txt

smokesignal/smoke-signal.php 92% from 13 tests

The main file in "SmokeSignal" v. 1.2.7 serves as a complement to information provided in readme.txt and as the entry point to the plugin
Please take the time to fix the following:
  • Main file name: The principal plugin file should be the same as the plugin slug ("smokesignal.php" instead of "smoke-signal.php")

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | A short check of programming languages and file extensions; no executable files are allowed
Good job! No executable or dangerous file extensions detected1,331 lines of code in 15 files:
LanguageFilesBlank linesComment linesLines of code
PHP122161241,121
PO File298126198
JavaScript13012

PHP code Passed 2 tests

A brief analysis of cyclomatic complexity and code structure for this plugin
Everything seems fine, there were no complexity issues found
Cyclomatic complexity
Average complexity per logical line of code0.25
Average class complexity13.33
▷ Minimum class complexity4.00
▷ Maximum class complexity29.00
Average method complexity1.76
▷ Minimum method complexity1.00
▷ Maximum method complexity6.00
Code structure
Namespaces0
Interfaces0
Traits0
Classes3
▷ Abstract classes00.00%
▷ Concrete classes3100.00%
▷ Final classes00.00%
Methods49
▷ Static methods4183.67%
▷ Public methods49100.00%
▷ Protected methods00.00%
▷ Private methods00.00%
Functions4
▷ Named functions4100.00%
▷ Anonymous functions00.00%
Constants8
▷ Global constants225.00%
▷ Class constants675.00%
▷ Public constants6100.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

It is recommended to compress PNG files in your plugin to minimize bandwidth usage
There were not PNG files found in your plugin