73% skyroom-wp

Code Review | Skyroom

WordPress plugin Skyroom scored 73% from 54 tests.

About plugin

  • Plugin page: skyroom-wp
  • Plugin version: 1.6.2
  • PHP compatiblity: 7.0+
  • PHP version: 7.4.16
  • WordPress compatibility: 5.0-6.2
  • WordPress version: 6.3.1
  • First release: Jul 15, 2020
  • Latest release: Apr 3, 2023
  • Number of updates: 18
  • Update frequency: every 55.1 days
  • Top authors: skyroom (100%)

Code review

54 tests

User reviews

3 reviews

Install metrics

300+ active / 13,428 total downloads

Benchmarks

Plugin footprint 65% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | Checking the installer triggered no errors
Install script ran successfully

Server metrics [RAM: ▲0.50MB] [CPU: ▲4.80ms] Passed 4 tests

An overview of server-side resources used by Skyroom
No issues were detected with server-side resource usage
PageMemory (MB)CPU Time (ms)
Home /3.91 ▲0.4545.67 ▲3.14
Dashboard /wp-admin3.86 ▲0.5652.54 ▲6.00
Posts /wp-admin/edit.php3.91 ▲0.5552.20 ▲5.59
Add New Post /wp-admin/post-new.php6.38 ▲0.4993.36 ▲4.46
Media Library /wp-admin/upload.php3.72 ▲0.4942.87 ▲8.57

Server storage [IO: ▲1.16MB] [DB: ▲0.00MB] Passed 3 tests

Analyzing filesystem and database footprints of this plugin
No storage issues were detected
Filesystem: 231 new files
Database: 1 new table, 7 new options
New tables
wp_skyroom_events
New WordPress options
theysaidso_admin_options
widget_theysaidso_widget
skyroom_db_version
can_compress_scripts
db_upgraded
widget_recent-comments
widget_recent-posts

Browser metrics Passed 4 tests

This is an overview of browser requirements for Skyroom
This plugin has a minimal impact on browser resources
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,842 ▲8513.35 ▼1.001.69 ▼0.5746.22 ▼3.22
Dashboard /wp-admin2,248 ▲604.95 ▼0.95124.29 ▲20.1743.51 ▼0.32
Posts /wp-admin/edit.php2,133 ▲412.09 ▲0.0935.44 ▲0.1833.91 ▼3.79
Add New Post /wp-admin/post-new.php1,549 ▲717.75 ▼0.48654.84 ▲31.3049.88 ▼8.93
Media Library /wp-admin/upload.php1,433 ▲454.28 ▼0.1096.21 ▼6.6242.76 ▼1.69

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 50% from 4 tests

🔸 Tests weight: 35 | All plugins must uninstall correctly, removing their source code and extra database tables they might have created
It is recommended to fix the following
  • Zombie tables were found after uninstall: 1 table
    • wp_skyroom_events
  • Zombie WordPress options detected upon uninstall: 7 options
    • db_upgraded
    • skyroom_db_version
    • can_compress_scripts
    • widget_recent-comments
    • widget_recent-posts
    • widget_theysaidso_widget
    • theysaidso_admin_options

Smoke tests 75% from 4 tests

Server-side errors Passed 1 test

🔹 Test weight: 20 | This is a shallow check for server-side errors
Even though no errors were found, this is by no means an exhaustive test

SRP 50% from 2 tests

🔹 Tests weight: 20 | SRP (Single-Responsibility Principle) - PHP files must act as libraries and never output text or perform any action when accessed directly in a browser
Please fix the following
  • 94× GET requests to PHP files have triggered server-side errors or warnings (only 10 are shown):
    • > PHP Fatal error
      Uncaught Error: Interface 'DI\\Definition\\Source\\DefinitionSource' not found in wp-content/plugins/skyroom-wp/vendor/php-di/php-di/src/DI/Definition/Source/Autowiring.php:14
    • > PHP Fatal error
      Uncaught Error: Interface 'DI\\Factory\\RequestedEntry' not found in wp-content/plugins/skyroom-wp/vendor/php-di/php-di/src/DI/Definition/Definition.php:12
    • > PHP Fatal error
      Uncaught Error: Class 'Skyroom\\Tables\\WPListTable' not found in wp-content/plugins/skyroom-wp/src/Skyroom/Tables/RoomsTable.php:12
    • > PHP Fatal error
      Uncaught Error: Class 'PHPUnit_Framework_TestCase' not found in wp-content/plugins/skyroom-wp/vendor/downshiftorg/wp-event-emitter/test/EventEmitterTest.php:5
    • > PHP Fatal error
      Uncaught Error: Interface 'DownShift\\WordPress\\EventEmitterInterface' not found in wp-content/plugins/skyroom-wp/vendor/downshiftorg/wp-event-emitter/src/EventEmitter.php:5
    • > PHP Fatal error
      Uncaught Error: Interface 'Invoker\\ParameterResolver\\ParameterResolver' not found in wp-content/plugins/skyroom-wp/vendor/php-di/invoker/src/ParameterResolver/ResolverChain.php:14
    • > PHP Fatal error
      Uncaught Error: Interface 'Ds\\Collection' not found in wp-content/plugins/skyroom-wp/vendor/php-ds/php-ds/src/Queue.php:13
    • > PHP Fatal error
      Uncaught Error: Call to undefined function DI\\object() in wp-content/plugins/skyroom-wp/config.php:19
    • > PHP Fatal error
      Uncaught Error: Class 'Skyroom\\Menu\\AbstractSubmenu' not found in wp-content/plugins/skyroom-wp/src/Skyroom/Menu/UserSubmenu.php:13
    • > PHP Fatal error
      Uncaught Error: Interface 'Invoker\\ParameterResolver\\ParameterResolver' not found in wp-content/plugins/skyroom-wp/vendor/php-di/php-di/src/DI/Invoker/DefinitionParameterResolver.php:16

User-side errors Passed 1 test

🔹 Test weight: 20 | This is a smoke test targeting browser errors/issues
Everything seems fine on the user side

Optimizations

Plugin configuration 87% from 29 tests

readme.txt 88% from 16 tests

The readme.txt file is an important file in your plugin as it is parsed by WordPress.org to prepare the public listing of your plugin
Attributes that need to be fixed:
  • Tags: There are too many tags (14 tag instead of maximum 10)
  • Screenshots: These screenshots require images: #1 (محیط افزونه اسکای روم Screenshot-1.PNG), #2 (محیط افزونه اسکای روم Screenshot-2.PNG), #3 (محیط افزونه اسکای روم Screenshot-3.PNG), #4 (محیط افزونه اسکای روم Screenshot-4.PNG)
You can take inspiration from this readme.txt

skyroom-wp/skyroom.php 85% from 13 tests

The primary PHP file in "Skyroom" version 1.6.2 is used by WordPress to initiate all plugin functionality
Please make the necessary changes and fix the following:
  • Text Domain: The text domain must be the same as the plugin slug, although optional since WordPress version 4.6
  • Main file name: The principal plugin file should be the same as the plugin slug ("skyroom-wp.php" instead of "skyroom.php")

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | A short check of programming languages and file extensions; no executable files are allowed
Everything looks great! No dangerous files found in this plugin19,630 lines of code in 213 files:
LanguageFilesBlank linesComment linesLines of code
PHP1742,3386,1728,996
JSON11008,518
Markdown1953601,244
PO File1165180375
JavaScript22110175
CSS33615161
YAML140130
XML23331

PHP code Passed 2 tests

A short review of cyclomatic complexity and code structure
All good! No complexity issues found
Cyclomatic complexity
Average complexity per logical line of code0.30
Average class complexity6.29
▷ Minimum class complexity1.00
▷ Maximum class complexity124.00
Average method complexity2.10
▷ Minimum method complexity1.00
▷ Maximum method complexity19.00
Code structure
Namespaces42
Interfaces25
Traits5
Classes126
▷ Abstract classes32.38%
▷ Concrete classes12397.62%
▷ Final classes118.94%
Methods844
▷ Static methods141.66%
▷ Public methods70984.00%
▷ Protected methods617.23%
▷ Private methods748.77%
Functions55
▷ Named functions1221.82%
▷ Anonymous functions4378.18%
Constants25
▷ Global constants00.00%
▷ Class constants25100.00%
▷ Public constants25100.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

Often times overlooked, PNG files can occupy unnecessary space in your plugin
7 PNG files occupy 0.20MB with 0.08MB in potential savings
Potential savings
Compression of 5 random PNG files using pngquant
FileSize - originalSize - compressedSavings
admin/images/icon-hover.png114.13KB39.92KB▼ 65.02%
admin/images/error.png7.31KB7.88KB0.00%
vendor/container-interop/container-interop/docs/images/side_by_side_containers.png15.88KB8.43KB▼ 46.90%
vendor/container-interop/container-interop/docs/images/priority.png15.87KB8.86KB▼ 44.20%
admin/images/skyroom-logo.png4.00KB2.61KB▼ 34.59%