10% scout-units-list

Code Review | Scout Units List

WordPress plugin Scout Units List scored10%from 54 tests.

About plugin

  • Plugin page: scout-units-list
  • Plugin version: 0.6.0
  • PHP version: 7.4.16
  • WordPress compatibility: 3.0.0-5.0
  • WordPress version: 6.3.1
  • First release: Nov 23, 2016
  • Latest release: Dec 31, 2018
  • Number of updates: 46
  • Update frequency: every 16.7 days
  • Top authors: duzymaju (100%)

Code review

54 tests

User reviews

1 review

Install metrics

10+ active /842 total downloads

Benchmarks

Plugin footprint 23% from 16 tests

Installer 0% from 1 test

🔺 Critical test (weight: 50) | Checking the installer triggered no errors
It is recommended to fix the following installer errors
  • This plugin did not install gracefully
    • > Warning in wp-content/plugins/scout-units-list/Model/Repository/VersionedRepository.php+35
    Declaration of ScoutUnitsList\Model\Repository\VersionedRepository::save(ScoutUnitsList\Model\VersionedModelInterface $model, $useVersioning = true) should be compatible with ScoutUnitsList\Model\Repository\Repository::save(ScoutUnitsList\Model\ModelInterface $model)

Server metrics [RAM: ▼1.95MB] [CPU: ▼56.35ms] Passed 4 tests

An overview of server-side resources used by Scout Units List
This plugin does not affect your website's performance
PageMemory (MB)CPU Time (ms)
Home /2.03 ▼1.434.42 ▼37.88
Dashboard /wp-admin2.05 ▼1.255.59 ▼48.02
Posts /wp-admin/edit.php2.06 ▼1.306.12 ▼41.43
Add New Post /wp-admin/post-new.php2.05 ▼3.836.04 ▼98.06
Media Library /wp-admin/upload.php2.06 ▼1.175.65 ▼30.57

Server storage [IO: ▲0.40MB] [DB: ▲0.08MB] Passed 3 tests

How much does this plugin use your filesystem and database?
No storage issues were detected
Filesystem: 159 new files
Database: 3 new tables, 7 new options
New tables
wp_sul_persons
wp_sul_units
wp_sul_positions
New WordPress options
theysaidso_admin_options
can_compress_scripts
widget_recent-posts
widget_theysaidso_widget
widget_recent-comments
db_upgraded
scout-units-list_config

Browser metrics Passed 4 tests

Scout Units List: an overview of browser usage
Normal browser usage
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,832 ▲9713.95 ▼0.401.67 ▼0.0244.89 ▲2.07
Dashboard /wp-admin2,228 ▲515.71 ▲0.09121.14 ▲29.3240.93 ▼2.79
Posts /wp-admin/edit.php2,125 ▲252.73 ▲0.7142.55 ▲5.6534.87 ▼4.43
Add New Post /wp-admin/post-new.php1,562 ▲3623.71 ▲0.53671.33 ▼18.5936.69 ▼30.36
Media Library /wp-admin/upload.php1,450 ▲535.16 ▲0.95101.76 ▼0.5141.03 ▼2.18

Uninstaller [IO: ▲0.00MB] [DB: ▲0.08MB] 25% from 4 tests

🔸 Tests weight: 35 | Checking the uninstaller removed all traces of the plugin
Please fix the following items
  • The plugin did not uninstall gracefully
    • > Warning in wp-content/plugins/scout-units-list/Model/Repository/VersionedRepository.php+35
    Declaration of ScoutUnitsList\Model\Repository\VersionedRepository::save(ScoutUnitsList\Model\VersionedModelInterface $model, $useVersioning = true) should be compatible with ScoutUnitsList\Model\Repository\Repository::save(ScoutUnitsList\Model\ModelInterface $model)
  • The uninstall procedure failed, leaving 3 tables in the database
    • wp_sul_units
    • wp_sul_positions
    • wp_sul_persons
  • Zombie WordPress options detected upon uninstall: 7 options
    • widget_theysaidso_widget
    • widget_recent-comments
    • theysaidso_admin_options
    • scout-units-list_config
    • can_compress_scripts
    • db_upgraded
    • widget_recent-posts

Smoke tests 75% from 4 tests

Server-side errors Passed 1 test

🔹 Test weight: 20 | This is a short smoke test looking for server-side errors
Good news, no errors were detected

SRP 50% from 2 tests

🔹 Tests weight: 20 | SRP (Single-Responsibility Principle) - PHP files must act as libraries and never output text or perform any action when accessed directly in a browser
Almost there! Just fix the following items
  • 80× GET requests to PHP files have triggered server-side errors or warnings (only 10 are shown):
    • > PHP Fatal error
      Uncaught Error: Class 'ScoutUnitsList\\Migration\\Version' not found in wp-content/plugins/scout-units-list/Migration/Version201703121442.php:12
    • > PHP Fatal error
      Uncaught Error: Interface 'ScoutUnitsList\\Validator\\Condition\\ConditionInterface' not found in wp-content/plugins/scout-units-list/Validator/Condition/DirExistsCondition.php:8
    • > PHP Fatal error
      Uncaught Error: Class 'ScoutUnitsList\\Form\\Field\\StringType' not found in wp-content/plugins/scout-units-list/Form/Field/StringHiddenType.php:8
    • > PHP Fatal error
      Uncaught Error: Class 'ScoutUnitsList\\Controller\\Controller' not found in wp-content/plugins/scout-units-list/Controller/Admin/UserController.php:12
    • > PHP Fatal error
      Uncaught Error: Class 'ScoutUnitsList\\Controller\\Controller' not found in wp-content/plugins/scout-units-list/Controller/Admin/UnitsController.php:23
    • > PHP Fatal error
      Uncaught Error: Interface 'ScoutUnitsList\\Validator\\Condition\\ConditionInterface' not found in wp-content/plugins/scout-units-list/Validator/Condition/NumericCompareCondition.php:8
    • > PHP Fatal error
      Uncaught Error: Class 'ScoutUnitsList\\Form\\Field\\BasicType' not found in wp-content/plugins/scout-units-list/Form/Field/SubmitType.php:10
    • > PHP Fatal error
      Uncaught Error: Class 'ScoutUnitsList\\Validator\\Condition\umericCompareCondition' not found in wp-content/plugins/scout-units-list/Validator/Condition/BetweenOrEqualsCondition.php:8
    • > PHP Fatal error
      Uncaught Error: Interface 'ScoutUnitsList\\Validator\\Condition\\ConditionInterface' not found in wp-content/plugins/scout-units-list/Validator/Condition/IntegerCondition.php:8
    • > PHP Fatal error
      Uncaught Error: Class 'ScoutUnitsList\\Model\\Repository\\Repository' not found in wp-content/plugins/scout-units-list/Model/Repository/PositionRepository.php:11

User-side errors Passed 1 test

🔹 Test weight: 20 | This is a smoke test targeting browser errors/issues
Everything seems fine on the user side

Optimizations

Plugin configuration 96% from 29 tests

readme.txt Passed 16 tests

Perhaps the most important file in your plugin readme.txt gets parsed in order to generate the public listing of your plugin
5 plugin tags: wosm, zhr, wagggs, scouts, zhp

scout-units-list/index.php 92% from 13 tests

The principal PHP file in "Scout Units List" v. 0.6.0 is loaded by WordPress automatically on each request
Please make the necessary changes and fix the following:
  • Main file name: The principal plugin file should be the same as the plugin slug ("scout-units-list.php" instead of "index.php")

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | There should be no dangerous file extensions present in any WordPress plugin
There were no executable files found in this plugin8,617 lines of code in 156 files:
LanguageFilesBlank linesComment linesLines of code
PHP1521,5754,3497,835
PO File1152181339
JavaScript1470328
CSS250115

PHP code Passed 2 tests

An short overview of logical lines of code, cyclomatic complexity, and other code metrics
All good! No complexity issues found
Cyclomatic complexity
Average complexity per logical line of code0.32
Average class complexity6.95
▷ Minimum class complexity1.00
▷ Maximum class complexity61.00
Average method complexity2.13
▷ Minimum method complexity1.00
▷ Maximum method complexity22.00
Code structure
Namespaces15
Interfaces3
Traits6
Classes102
▷ Abstract classes109.80%
▷ Concrete classes9290.20%
▷ Final classes11.09%
Methods598
▷ Static methods91.51%
▷ Public methods47479.26%
▷ Protected methods7512.54%
▷ Private methods498.19%
Functions8
▷ Named functions112.50%
▷ Anonymous functions787.50%
Constants63
▷ Global constants00.00%
▷ Class constants63100.00%
▷ Public constants63100.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

All PNG images should be compressed to minimize bandwidth usage for end users
No PNG images were found in this plugin