78% pronamic-ideal

Code Review | Pronamic Pay

WordPress plugin Pronamic Pay scored78%from 54 tests.

About plugin

  • Plugin page: pronamic-ideal
  • Plugin version: 9.6.3
  • PHP compatiblity: 8.0+
  • PHP version: 7.4.16
  • WordPress compatibility: 5.9-6.4
  • WordPress version: 6.3.1
  • First release: Aug 20, 2011
  • Latest release: Nov 15, 2023
  • Number of updates: 608
  • Update frequency: every 7.4 days
  • Top authors: remcotolsma (48.52%)pronamic (48.19%)pronamic_reuel (3.62%)

Code review

54 tests

User reviews

83 reviews

Install metrics

4,000+ active /378,362 total downloads

Benchmarks

Plugin footprint 83% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | The install procedure must perform silently
Install script ran successfully

Server metrics [RAM: ▲0.00MB] [CPU: ▼2.62ms] Passed 4 tests

A check of server-side resources used by Pronamic Pay
Normal server usage
PageMemory (MB)CPU Time (ms)
Home /3.46 ▲0.0032.00 ▼8.61
Dashboard /wp-admin3.31 ▲0.0051.44 ▲1.93
Posts /wp-admin/edit.php3.36 ▲0.0048.17 ▲3.45
Add New Post /wp-admin/post-new.php5.89 ▲0.0089.36 ▼2.39
Media Library /wp-admin/upload.php3.23 ▲0.0031.39 ▼1.39

Server storage [IO: ▲20.85MB] [DB: ▲0.00MB] Passed 3 tests

A short overview of filesystem and database impact
This plugin installed successfully
Filesystem: 2,503 new files
Database: no new tables, 6 new options
New WordPress options
theysaidso_admin_options
can_compress_scripts
widget_theysaidso_widget
widget_recent-posts
db_upgraded
widget_recent-comments

Browser metrics Passed 4 tests

A check of browser resources used by Pronamic Pay
Minimal impact on browser resources
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,790 ▲314.36 ▲0.121.65 ▼0.4037.75 ▼6.65
Dashboard /wp-admin2,195 ▲245.62 ▼0.0091.96 ▼8.1935.87 ▼7.72
Posts /wp-admin/edit.php2,100 ▼31.95 ▼0.0739.98 ▼2.5937.30 ▼0.71
Add New Post /wp-admin/post-new.php1,526 ▼323.58 ▲0.26694.76 ▼4.9761.71 ▼1.08
Media Library /wp-admin/upload.php1,400 ▼04.19 ▼0.1397.75 ▼12.2943.24 ▼1.78

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 75% from 4 tests

🔸 Tests weight: 35 | Verifying that this plugin uninstalls completely without leaving any traces
These items require your attention
  • The uninstall procedure has failed, leaving 6 options in the database
    • db_upgraded
    • widget_recent-posts
    • widget_recent-comments
    • can_compress_scripts
    • widget_theysaidso_widget
    • theysaidso_admin_options

Smoke tests 50% from 4 tests

Server-side errors Passed 1 test

🔹 Test weight: 20 | This is a short smoke test looking for server-side errors
Good news, no errors were detected

SRP 0% from 2 tests

🔹 Tests weight: 20 | The single-responsibility principle: PHP files have to remain inert when accessed directly, throwing no errors and performing no actions
The following issues need your attention
  • 5× PHP files perform the action of outputting non-empty strings when accessed directly:
    • > /wp-content/plugins/pronamic-ideal/vendor/pronamic/icepay-soap-api/samples/sample_pbm_createlink.php
    • > /wp-content/plugins/pronamic-ideal/vendor/pronamic/icepay-soap-api/samples/sample_filter.php
    • > /wp-content/plugins/pronamic-ideal/vendor/pronamic/icepay-soap-api/samples/sample_ideal.php
    • > /wp-content/plugins/pronamic-ideal/vendor/pronamic/icepay-soap-api/samples/sample_webservice_filteringpaymentmethods.php
    • > /wp-content/plugins/pronamic-ideal/vendor/pronamic/icepay-soap-api/samples/sample_basicmode.php
  • 527× PHP files trigger server-side errors or warnings when accessed directly (only 10 are shown):
    • > PHP Fatal error
      Uncaught Error: Class 'SoapClient' not found in wp-content/plugins/pronamic-ideal/vendor/pronamic/icepay-soap-api/src/icepay_api_webservice.php:191
    • > PHP Fatal error
      Uncaught Error: Class 'ActionScheduler_Logger' not found in wp-content/plugins/pronamic-ideal/packages/woocommerce/action-scheduler/classes/data-stores/ActionScheduler_wpCommentLogger.php:6
    • > PHP Fatal error
      Uncaught Error: Class 'Composer\\Installers\\BaseInstaller' not found in wp-content/plugins/pronamic-ideal/vendor/composer/installers/src/Composer/Installers/AnnotateCmsInstaller.php:5
    • > PHP Fatal error
      Uncaught Error: Class 'Pronamic\\WordPress\\Pay\\Payments\\LegacyPaymentsDataStoreCPT' not found in wp-content/plugins/pronamic-ideal/packages/wp-pay/core/src/Payments/PaymentsDataStoreCPT.php:32
    • > PHP Fatal error
      Uncaught Error: Class 'Pronamic\\WordPress\\Pay\\Gateways\\Adyen\\ResponseObject' not found in wp-content/plugins/pronamic-ideal/packages/wp-pay-gateways/adyen/src/PaymentMethodsResponse.php:22
    • > PHP Fatal error
      Uncaught Error: Using $this when not in object context in wp-content/plugins/pronamic-ideal/packages/wp-pay-extensions/gravityforms/views/html-admin-feed-settings.php:17
    • > PHP Fatal error
      Uncaught Error: Class 'Pronamic\\WordPress\\Pay\\Upgrades\\Upgrade' not found in wp-content/plugins/pronamic-ideal/packages/wp-pay-extensions/woocommerce/src/Upgrade420.php:24
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_filter() in wp-content/plugins/pronamic-ideal/packages/wp-pay-extensions/restrict-content-pro/pronamic-pay-rcp.php:30
    • > PHP Fatal error
      Uncaught Error: Class 'SoapClient' not found in wp-content/plugins/pronamic-ideal/vendor/pronamic/icepay-soap-api/src/icepay_api_webservice.php:191
    • > PHP Fatal error
      Uncaught Error: Class 'Composer\\Installers\\BaseInstaller' not found in wp-content/plugins/pronamic-ideal/vendor/composer/installers/src/Composer/Installers/ProcessWireInstaller.php:5

User-side errors Passed 1 test

🔹 Test weight: 20 | Just a short smoke test targeting errors on the browser (console and network errors and warnings)
There were no browser issues found

Optimizations

Plugin configuration 93% from 29 tests

readme.txt 94% from 16 tests

You should put a lot of thought into formatting readme.txt as it is used by WordPress.org to prepare the public listing of your plugin
These attributes need your attention:
  • Tags: Please delete some tags, you are using 18 tag instead of maximum 10
The official readme.txt might help

pronamic-ideal/pronamic-ideal.php 92% from 13 tests

The entry point to "Pronamic Pay" version 9.6.3 is a PHP file that has certain tags in its header comment area
It is important to fix the following:
  • Description: Please don't use more than 140 characters for the plugin description (currently 148 characters long)

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | A short review of files and their extensions; it is not recommended to include executable files
Good job! No executable or dangerous file extensions detected155,926 lines of code in 1,415 files:
LanguageFilesBlank linesComment linesLines of code
PHP1,06222,96357,35981,128
JSON13331027,754
PO File98,72414,12022,838
Markdown863,883011,903
JavaScript342,3972,3078,210
XML72512,073
CSS21152341,364
SVG5401291
HTML1550150
YAML4340129
Sass1302074
reStructuredText312412

PHP code Passed 2 tests

An short overview of logical lines of code, cyclomatic complexity, and other code metrics
Great job! No cyclomatic complexity issues were detected in this plugin
Cyclomatic complexity
Average complexity per logical line of code0.30
Average class complexity8.63
▷ Minimum class complexity1.00
▷ Maximum class complexity211.00
Average method complexity2.47
▷ Minimum method complexity1.00
▷ Maximum method complexity57.00
Code structure
Namespaces83
Interfaces19
Traits9
Classes881
▷ Abstract classes424.77%
▷ Concrete classes83995.23%
▷ Final classes20.24%
Methods4,662
▷ Static methods62713.45%
▷ Public methods4,08087.52%
▷ Protected methods2585.53%
▷ Private methods3246.95%
Functions223
▷ Named functions4017.94%
▷ Anonymous functions18382.06%
Constants707
▷ Global constants405.66%
▷ Class constants66794.34%
▷ Public constants667100.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

Using a strong compression for your PNG files is a great way to speed-up your plugin
993 compressed PNG files occupy 7.48MB
Potential savings
Compression of 5 random PNG files using pngquant
FileSize - originalSize - compressedSavings
images/bancontact/icon-64x64@3x.png4.30KB3.42KB▼ 20.49%
images/van-lanschot/icon-125x60.png1.58KB1.81KB0.00%
packages/wp-pay/core/images/dist/cards/handelsbanken/card-handelsbanken-logo-_x80@3x.png6.69KB6.64KB▼ 0.77%
images/direct-debit-sofort/icon-125x60@2x.png2.28KB2.23KB▼ 2.31%
packages/wp-pay/core/images/dist/cards/ing/card-ing-logo-_x80@2x.png7.92KB7.87KB▼ 0.70%