66% popup-more

Code Review | Popup More Popups, Lightboxes, and more popup modules

WordPress plugin Popup More Popups, Lightboxes, and more popup modules scored66%from 54 tests.

About plugin

  • Plugin page: popup-more
  • Plugin version: 2.1.5
  • PHP version: 7.4.16
  • WordPress compatibility: 3.8-6.4
  • WordPress version: 6.3.1
  • First release: Dec 25, 2020
  • Latest release: Nov 25, 2023
  • Number of updates: 267
  • Update frequency: every 4.0 days
  • Top authors: devfelixmoira (100%)

Code review

54 tests

User reviews

8 reviews

Install metrics

300+ active /31,537 total downloads

Benchmarks

Plugin footprint 83% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | It is important to correctly install your plugin, without throwing errors or notices
Installer ran successfully

Server metrics [RAM: ▲0.39MB] [CPU: ▼3.11ms] Passed 4 tests

Server-side resources used by Popup More Popups, Lightboxes, and more popup modules
This plugin has minimal impact on server resources
PageMemory (MB)CPU Time (ms)
Home /3.83 ▲0.3738.39 ▼1.17
Dashboard /wp-admin3.69 ▲0.3550.31 ▼7.93
Posts /wp-admin/edit.php3.81 ▲0.4550.27 ▲0.12
Add New Post /wp-admin/post-new.php6.36 ▲0.4788.95 ▼3.45
Media Library /wp-admin/upload.php3.62 ▲0.3941.15 ▲7.22
Subscription module /wp-admin/edit.php?post_type=ypmsubscription3.7642.91
Social module (Pro) /wp-admin/edit.php?post_type=ypmsocial3.6840.61
Iframe module (Pro) /wp-admin/edit.php?post_type=ypmiframe3.6939.15
Settings /wp-admin/edit.php?post_type=popupmaster&page=ypmSettingsPage3.6341.53
Dynamic Link Content module (Pro) /wp-admin/edit.php?post_type=ypmlink3.6837.90
Add New /wp-admin/post-new.php?post_type=popupmaster3.9456.38
Popup Types /wp-admin/edit.php?post_type=popupmaster&page=popupmaster3.6548.74
Facebook module /wp-admin/edit.php?post_type=ypmfacebook3.6936.16
Youtube module /wp-admin/edit.php?post_type=ypmyoutube3.6937.99
Countdown module (Pro) /wp-admin/edit.php?post_type=ypmcountdown3.6838.57

Server storage [IO: ▲2.24MB] [DB: ▲0.07MB] Passed 3 tests

A short overview of filesystem and database impact
This plugin was installed successfully
Filesystem: 254 new files
Database: 3 new tables, 10 new options
New tables
wp_ypm_subscribers
wp_ypm_contact_form_fields
wp_ypm_subscription_form_fields
New WordPress options
can_compress_scripts
YpmInstallDate
YpmShowNextTime
theysaidso_admin_options
YpmUsageDays
ypm_redirect
db_upgraded
widget_theysaidso_widget
widget_recent-comments
widget_recent-posts

Browser metrics Passed 4 tests

This is an overview of browser requirements for Popup More Popups, Lightboxes, and more popup modules
This plugin has a minimal impact on browser resources
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,944 ▲19714.28 ▼0.071.74 ▲0.0440.73 ▼2.30
Dashboard /wp-admin2,344 ▲1705.67 ▲0.0995.41 ▲1.5943.23 ▲2.03
Posts /wp-admin/edit.php2,249 ▲1462.09 ▲0.0235.63 ▼10.1532.97 ▼5.02
Add New Post /wp-admin/post-new.php6,407 ▲4,87426.22 ▲2.98946.75 ▲326.3260.54 ▲7.68
Media Library /wp-admin/upload.php1,549 ▲1464.21 ▲0.0195.93 ▼0.5042.73 ▲2.74
Subscription module /wp-admin/edit.php?post_type=ypmsubscription1,1912.3143.9741.76
Social module (Pro) /wp-admin/edit.php?post_type=ypmsocial1,2022.0535.8632.72
Iframe module (Pro) /wp-admin/edit.php?post_type=ypmiframe1,2012.0137.5529.69
Settings /wp-admin/edit.php?post_type=popupmaster&page=ypmSettingsPage1,2422.3145.5127.30
Dynamic Link Content module (Pro) /wp-admin/edit.php?post_type=ypmlink1,1992.0433.6730.71
Add New /wp-admin/post-new.php?post_type=popupmaster6,7169.22364.83167.97
Popup Types /wp-admin/edit.php?post_type=popupmaster&page=popupmaster1,6102.3238.1566.77
Facebook module /wp-admin/edit.php?post_type=ypmfacebook1,1962.0938.0430.34
Youtube module /wp-admin/edit.php?post_type=ypmyoutube1,2042.4837.6229.43
Countdown module (Pro) /wp-admin/edit.php?post_type=ypmcountdown1,1992.0433.9330.57

Uninstaller [IO: ▲0.00MB] [DB: ▲0.07MB] 75% from 4 tests

🔸 Tests weight: 35 | The uninstall procedure must remove all plugin files and extra database tables
Please fix the following items
  • This plugin does not fully uninstall, leaving 6 options in the database
    • widget_recent-posts
    • can_compress_scripts
    • db_upgraded
    • theysaidso_admin_options
    • widget_theysaidso_widget
    • widget_recent-comments

Smoke tests 0% from 4 tests

Server-side errors 0% from 1 test

🔹 Test weight: 20 | A smoke test targeting server-side errors
These errors were triggered by the plugin
    • > GET request to /wp-admin/post-new.php?post_type=popupmaster
    • > Notice in wp-content/plugins/popup-more/assets/view/info.php+6
    Undefined index: post
  • 3 occurences, only the last one shown
    • > GET request to /wp-admin/post-new.php?post_type=popupmaster
    • > Notice in wp-content/plugins/popup-more/classes/admin/conditionsBuilder/ConditionBuilder.php+203
    Undefined index: select_settings

SRP 0% from 2 tests

🔹 Tests weight: 20 | SRP (Single-Responsibility Principle) - PHP files must act as libraries and never output text or perform any action when accessed directly in a browser
Almost there! Just fix the following items
  • 2× PHP files perform the action of outputting non-empty strings when accessed directly:
    • > /wp-content/plugins/popup-more/assets/view/upgrade.php
    • > /wp-content/plugins/popup-more/assets/view/support.php
  • 100× GET requests to PHP files have triggered server-side errors or warnings (only 10 are shown):
    • > PHP Warning
      require_once(YPM_POPUP_HELPERSConfigDataHelper.php): failed to open stream: No such file or directory in wp-content/plugins/popup-more/config/data-config.php on line 3
    • > PHP Fatal error
      Uncaught Error: Class 'YpmAdminHelper' not found in wp-content/plugins/popup-more/assets/view/gamification/contents.php:2
    • > PHP Fatal error
      Uncaught Error: Class 'YpmPopupData' not found in wp-content/plugins/popup-more/assets/view/metaboxes/general/generalView/themes.php:2
    • > PHP Warning
      Use of undefined constant YPM_POPUP_FREE - assumed 'YPM_POPUP_FREE' (this will throw an Error in a future version of PHP) in wp-content/plugins/popup-more/classes/popups/YoutubePopup.php on line 6
    • > PHP Fatal error
      Uncaught Error: Call to a member function getOptionValue() on null in wp-content/plugins/popup-more/assets/view/gamification/design.php:2
    • > PHP Notice
      Undefined index: post in wp-content/plugins/popup-more/assets/view/iframe.php on line 6
    • > PHP Fatal error
      Uncaught Error: Call to undefined function YpmPopup\\add_action() in wp-content/plugins/popup-more/classes/admin/AdminPost.php:13
    • > PHP Warning
      Use of undefined constant YPM_POPUP_FREE - assumed 'YPM_POPUP_FREE' (this will throw an Error in a future version of PHP) in wp-content/plugins/popup-more/classes/Ajax.php on line 10
    • > PHP Warning
      Use of undefined constant YPM_POPUP_HELPERS - assumed 'YPM_POPUP_HELPERS' (this will throw an Error in a future version of PHP) in wp-content/plugins/popup-more/assets/view/gamification/main.php on line 2
    • > PHP Warning
      require_once(YPM_POPUP_HELPERS/Tabs.php): failed to open stream: No such file or directory in wp-content/plugins/popup-more/assets/view/gamification/main.php on line 2

User-side errors 0% from 1 test

🔹 Test weight: 20 | This is a smoke test targeting browser errors/issues
There are user-side issues you should fix
    • > GET request to /wp-admin/edit.php?post_type=ypmiframe
    • > Network (severe)
    wp-content/plugins/popup-more/assets/javascript/admin//iframe.js?ver=6.3.1 - Failed to load resource: the server responded with a status of 404 (Not Found)
  • 3 occurences, only the last one shown
    • > GET request to /wp-admin/edit.php?post_type=popupmaster&page=popupmaster
    • > Network (severe)
    wp-content/plugins/popup-more/assets/css/colorbox/ypmcolorbox.css?ver=2.15 - Failed to load resource: the server responded with a status of 404 (Not Found)

Optimizations

Plugin configuration 97% from 29 tests

readme.txt 94% from 16 tests

The readme.txt file is important because it is parsed by WordPress.org for the public listing of your plugin
These attributes need your attention:
  • Tags: Please delete some tags, you are using 12 tag instead of maximum 10
The official readme.txt is a good inspiration

popup-more/popup-more.php Passed 13 tests

The main PHP file in "Popup More Popups, Lightboxes, and more popup modules" ver. 2.1.5 adds more information about the plugin and also serves as the entry point for this plugin
77 characters long description:
Popup More is the most complete pop up plugin in the WordPress popup plugins.

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | An overview of files in this plugin; executable files are not allowed
Good job! No executable or dangerous file extensions detected29,024 lines of code in 151 files:
LanguageFilesBlank linesComment linesLines of code
PHP1071,93184212,495
JavaScript222,36655610,224
CSS197312306,173
PO File15618130
SVG2002

PHP code Passed 2 tests

This plugin's cyclomatic complexity and code structure detailed below
All good! No complexity issues found
Cyclomatic complexity
Average complexity per logical line of code0.22
Average class complexity16.20
▷ Minimum class complexity1.00
▷ Maximum class complexity117.00
Average method complexity2.43
▷ Minimum method complexity1.00
▷ Maximum method complexity58.00
Code structure
Namespaces5
Interfaces1
Traits0
Classes59
▷ Abstract classes46.78%
▷ Concrete classes5593.22%
▷ Final classes00.00%
Methods635
▷ Static methods13921.89%
▷ Public methods52382.36%
▷ Protected methods284.41%
▷ Private methods8413.23%
Functions17
▷ Named functions741.18%
▷ Anonymous functions1058.82%
Constants84
▷ Global constants84100.00%
▷ Class constants00.00%
▷ Public constants00.00%

Plugin size 50% from 2 tests

Image compression 50% from 2 tests

Often times overlooked, PNG files can occupy unnecessary space in your plugin
84 PNG files occupy 0.64MB with 0.17MB in potential savings
Potential savings
Compression of 5 random PNG files using pngquant
FileSize - originalSize - compressedSavings
assets/css/jQueryDialog/images/ui-bg_fine-grain_68_b83400_60x60.png8.11KB2.26KB▼ 72.15%
assets/img/colorbox4/images/border1.png0.61KB0.82KB0.00%
assets/img/colorbox1/close.png0.83KB0.40KB▼ 51.58%
assets/img/colorbox5/images/controls.png1.98KB2.04KB0.00%
assets/img/conf-home.png1.55KB1.36KB▼ 11.87%