73% popup-maker

Code Review | Popup Maker - Popup for opt-ins, lead gen, & more

WordPress plugin Popup Maker - Popup for opt-ins, lead gen, & more scored73%from 54 tests.

About plugin

  • Plugin page: popup-maker
  • Plugin version: 1.18.2
  • PHP compatiblity: 5.6+
  • PHP version: 7.4.16
  • WordPress compatibility: 4.9-6.3.0
  • WordPress version: 6.3.1
  • First release: Nov 17, 2014
  • Latest release: Aug 15, 2023
  • Number of updates: 402
  • Update frequency: every 8.0 days
  • Top authors: danieliser (89.8%)fpcorso (8.71%)waltmesser (1.24%)codeatlantic (1%)

Code review

54 tests

User reviews

4409 reviews

Install metrics

700,000+ active /13,518,319 total downloads

Benchmarks

Plugin footprint 65% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | Checking the installer triggered no errors
Installer ran successfully

Server metrics [RAM: ▲3.42MB] [CPU: ▲36.43ms] 75% from 4 tests

Analyzing server-side resources used by Popup Maker - Popup for opt-ins, lead gen, & more
Please take the time to fix the following items
  • RAM: Try to keep total memory usage under 10MB (currently 10.27MB on /wp-admin/edit.php?post_type=popup&page=pum-settings)
PageMemory (MB)CPU Time (ms)
Home /10.37 ▲6.91119.97 ▲76.22
Dashboard /wp-admin6.63 ▲3.33116.24 ▲57.50
Posts /wp-admin/edit.php6.65 ▲3.2979.54 ▲27.83
Add New Post /wp-admin/post-new.php9.69 ▲3.80119.90 ▲19.02
Media Library /wp-admin/upload.php6.47 ▲3.2575.90 ▲41.35
Settings /wp-admin/edit.php?post_type=popup&page=pum-settings10.2792.92
Tools /wp-admin/edit.php?post_type=popup&page=pum-tools6.4762.11
Upgrade /wp-admin/edit.php?post_type=popup&page=pum-extensions6.4462.67
All Popups /wp-admin/edit.php?post_type=popup7.0577.77
Subscribers /wp-admin/edit.php?post_type=popup&page=pum-subscribers6.7782.00
Popup Themes /wp-admin/edit.php?post_type=popup_theme6.6873.20
Help & Support /wp-admin/edit.php?post_type=popup&page=pum-support6.4259.63
Create Popup /wp-admin/post-new.php?post_type=popup7.9298.96

Server storage [IO: ▲3.90MB] [DB: ▲0.55MB] Passed 3 tests

Filesystem and database footprint
The plugin installed successfully
Filesystem: 372 new files
Database: 1 new table, 26 new options
New tables
wp_pum_subscribers
New WordPress options
widget_theysaidso_widget
_pum_installed
pum_db_ver
theysaidso_admin_options
pum_seen_welcome
pum_subscribers_db_version
_pum_installed_themes
pum-has-cached-js
pum_installed_on
_pum_writeable_notice_dismissed
...

Browser metrics Passed 4 tests

A check of browser resources used by Popup Maker - Popup for opt-ins, lead gen, & more
This plugin renders optimally with no browser resource issues detected
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /3,145 ▲39913.57 ▼0.896.16 ▲3.9443.75 ▲1.18
Dashboard /wp-admin2,420 ▲2294.90 ▲0.06109.95 ▲5.2338.02 ▼6.01
Posts /wp-admin/edit.php2,315 ▲2262.04 ▼0.0039.60 ▲1.4235.37 ▼0.86
Add New Post /wp-admin/post-new.php1,927 ▲39420.21 ▼2.81730.16 ▲47.0337.76 ▼21.03
Media Library /wp-admin/upload.php1,603 ▲2124.36 ▲0.1199.24 ▼1.1243.54 ▲1.82
Settings /wp-admin/edit.php?post_type=popup&page=pum-settings2,0833.6166.6130.51
Tools /wp-admin/edit.php?post_type=popup&page=pum-tools1,0202.0626.1330.79
Upgrade /wp-admin/edit.php?post_type=popup&page=pum-extensions1,8662.0828.9546.04
All Popups /wp-admin/edit.php?post_type=popup2,2492.7856.3255.15
Subscribers /wp-admin/edit.php?post_type=popup&page=pum-subscribers1,2142.0926.9829.48
Popup Themes /wp-admin/edit.php?post_type=popup_theme2,5342.0839.1332.00
Help & Support /wp-admin/edit.php?post_type=popup&page=pum-support1,9025.93155.4966.53
Create Popup /wp-admin/post-new.php?post_type=popup4,4828.80268.0680.75

Uninstaller [IO: ▲0.08MB] [DB: ▲0.55MB] 50% from 4 tests

🔸 Tests weight: 35 | Verifying that this plugin uninstalls completely without leaving any traces
It is recommended to fix the following
  • This plugin does not fully uninstall, leaving 1 table in the database
    • wp_pum_subscribers
  • The uninstall procedure has failed, leaving 26 options in the database
    • pum_privacy_cookie_list
    • widget_theysaidso_widget
    • _pum_installed_themes
    • pum_seen_welcome
    • pum_completed_upgrades
    • pum_files_writeable
    • pum_debug_log_token
    • pum_ver_upgraded_from
    • can_compress_scripts
    • widget_recent-comments
    • ...

Smoke tests 75% from 4 tests

Server-side errors Passed 1 test

🔹 Test weight: 20 | A smoke test targeting server-side errors
Everything seems fine, however this is by no means an exhaustive test

SRP 50% from 2 tests

🔹 Tests weight: 20 | A shallow check of the single-responsibility principle; PHP files should perform no action - including output of placeholder text - and trigger no errors when accessed directly
Please take a closer look at the following
  • 27× GET requests to PHP files have triggered server-side errors or warnings (only 10 are shown):
    • > PHP Fatal error
      require_once(): Failed opening required 'ABSPATHwp-admin/includes/nav-menu.php' (include_path='.:/usr/share/php') in wp-content/plugins/popup-maker/includes/modules/menus/class-nav-menu-edit-custom-fields.php on line 9
    • > PHP Fatal error
      Uncaught Error: Class 'PUM_Abstract_Integration' not found in wp-content/plugins/popup-maker/classes/Abstract/Integration/Form.php:9
    • > PHP Fatal error
      Uncaught Error: Class 'PUM_Abstract_Integration_Form' not found in wp-content/plugins/popup-maker/classes/Integration/Form/NinjaForms.php:9
    • > PHP Fatal error
      Uncaught Error: Class 'PUM_Abstract_Integration_Form' not found in wp-content/plugins/popup-maker/classes/Integration/Form/GravityForms.php:9
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_action() in wp-content/plugins/popup-maker/includes/functions/themes/migrations.php:83
    • > PHP Fatal error
      require_once(): Failed opening required 'ABSPATHwp-admin/includes/nav-menu.php' (include_path='.:/usr/share/php') in wp-content/plugins/popup-maker/includes/modules/menus/class-nav-menu-edit-custom-fields-deprecated.php on line 5
    • > PHP Fatal error
      Uncaught Error: Interface 'PUM_Interface_Integration' not found in wp-content/plugins/popup-maker/classes/Abstract/Integration.php:9
    • > PHP Warning
      require_once(ABSPATHwp-admin/includes/nav-menu.php): failed to open stream: No such file or directory in wp-content/plugins/popup-maker/includes/modules/menus/class-nav-menu-edit-custom-fields.php on line 9
    • > PHP Fatal error
      Uncaught Error: Class 'PUM_Abstract_Integration' not found in wp-content/plugins/popup-maker/classes/Integration/Builder/KingComposer.php:9
    • > PHP Fatal error
      Uncaught Error: Class 'PUM_Abstract_Integration_Form' not found in wp-content/plugins/popup-maker/classes/Integration/Form/WPForms.php:9

User-side errors Passed 1 test

🔹 Test weight: 20 | This is just a short smoke test looking for browser issues
There were no browser issues found

Optimizations

Plugin configuration 93% from 29 tests

readme.txt 88% from 16 tests

Often overlooked, readme.txt is one of the most important files in your plugin
These attributes need your attention:
  • Donate link: Invalid URI ("")
  • Tags: You are using too many tags: 11 tag instead of maximum 10
The official readme.txt is a good inspiration

popup-maker/popup-maker.php Passed 13 tests

"Popup Maker - Popup for opt-ins, lead gen, & more" version 1.18.2's primary PHP file adds more information about the plugin and serves as the entry point for WordPress
135 characters long description:
Easily create & style popups with any content. Theme editor to quickly style your popups. Add forms, social media boxes, videos & more.

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | This is an overview of programming languages used in this plugin; dangerous file extensions are not allowed
Good job! No executable or dangerous file extensions detected66,242 lines of code in 294 files:
LanguageFilesBlank linesComment linesLines of code
PHP2026,45013,74224,919
JSON20018,845
JavaScript433,2992,79215,766
CSS451,3035256,483
XML1416226
SVG1003

PHP code Passed 2 tests

Cyclomatic complexity and code structure are the fingerprint of this plugin
There were no cyclomatic complexity issued detected
Cyclomatic complexity
Average complexity per logical line of code0.45
Average class complexity19.18
▷ Minimum class complexity1.00
▷ Maximum class complexity139.00
Average method complexity3.19
▷ Minimum method complexity1.00
▷ Maximum method complexity29.00
Code structure
Namespaces0
Interfaces12
Traits0
Classes151
▷ Abstract classes1610.60%
▷ Concrete classes13589.40%
▷ Final classes85.93%
Methods1,413
▷ Static methods62644.30%
▷ Public methods1,32093.42%
▷ Protected methods694.88%
▷ Private methods241.70%
Functions227
▷ Named functions227100.00%
▷ Anonymous functions00.00%
Constants13
▷ Global constants1076.92%
▷ Class constants323.08%
▷ Public constants3100.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

PNG files should be compressed to save space and minimize bandwidth usage
32 compressed PNG files occupy 0.16MB
Potential savings
Compression of 5 random PNG files using pngquant
FileSize - originalSize - compressedSavings
assets/images/admin/icon-info-21x21.png0.46KB0.45KB▼ 3.38%
assets/images/extensions/forced-interaction.png1.51KB2.20KB0.00%
assets/images/upsell-icon-forced-interaction.png0.30KB0.32KB0.00%
assets/images/support-pane-docs-icon.png0.25KB0.28KB0.00%
assets/images/extensions/age-verification-modals.png2.34KB2.69KB0.00%