63% oneds-start

Code Review | OneDS Start Package

WordPress plugin OneDS Start Package scored63%from 54 tests.

About plugin

  • Plugin page: oneds-start
  • Plugin version: 0.5
  • PHP version: 7.4.16
  • WordPress version: 6.3.1
  • First release: Aug 6, 2015
  • Latest release: Jun 21, 2022
  • Number of updates: 17
  • Update frequency: every 147.8 days
  • Top authors: king-a-s (100%)

Code review

54 tests

User reviews

1 review

Install metrics

20+ active /1,047 total downloads

Benchmarks

Plugin footprint 65% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | Checking the installer triggered no errors
The plugin installed gracefully, with no errors

Server metrics [RAM: ▲0.04MB] [CPU: ▼29.38ms] Passed 4 tests

Server-side resources used by OneDS Start Package
Server-side resource usage in normal parameters
PageMemory (MB)CPU Time (ms)
Home /3.87 ▲0.4022.94 ▼15.84
Dashboard /wp-admin4.10 ▲0.8029.16 ▼18.25
Posts /wp-admin/edit.php4.11 ▲0.7425.49 ▼20.37
Add New Post /wp-admin/post-new.php4.10 ▼1.7927.22 ▼63.04
Media Library /wp-admin/upload.php4.10 ▲0.8724.29 ▼9.77
Tools /wp-admin/edit.php?post_type=acf-field-group&page=acf-tools4.1126.09
Add New /wp-admin/post-new.php?post_type=optionspage4.1124.18
Add New /wp-admin/post-new.php?post_type=acf-field-group4.1123.75
Options Pages /wp-admin/edit.php?post_type=optionspage4.1124.84
Field Groups /wp-admin/edit.php?post_type=acf-field-group4.1123.43

Server storage [IO: ▲8.82MB] [DB: ▲0.05MB] Passed 3 tests

Analyzing filesystem and database footprints of this plugin
This plugin was installed successfully
Filesystem: 279 new files
Database: no new tables, 8 new options
New WordPress options
odsmm-content-default
theysaidso_admin_options
widget_recent-comments
widget_theysaidso_widget
widget_recent-posts
acf_version
db_upgraded
can_compress_scripts

Browser metrics Passed 4 tests

OneDS Start Package: an overview of browser usage
Normal browser usage
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /3,176 ▲41514.19 ▼0.152.22 ▲0.4331.25 ▼8.51
Dashboard /wp-admin2,538 ▲3576.11 ▲0.40123.79 ▲25.7952.37 ▲10.00
Posts /wp-admin/edit.php2,244 ▲1443.11 ▲1.1349.66 ▲10.3433.36 ▼1.78
Add New Post /wp-admin/post-new.php6,774 ▲5,24824.11 ▲1.10964.98 ▲373.9950.39 ▲1.90
Media Library /wp-admin/upload.php2,033 ▲6338.34 ▲4.02217.72 ▲119.0151.56 ▲11.20
Tools /wp-admin/edit.php?post_type=acf-field-group&page=acf-tools1,2452.9142.7831.52
Add New /wp-admin/post-new.php?post_type=optionspage2,1788.54150.5233.97
Add New /wp-admin/post-new.php?post_type=acf-field-group2,4053.8977.5367.18
Theme Options /wp-admin/theme-options.php260.420.0915.31
Dashboard Options /wp-admin/dashboard-options.php260.420.096.83
Options Pages /wp-admin/edit.php?post_type=optionspage1,8373.0850.1230.72
Maintenance Mode /wp-admin/maintenance-mode-options.php260.420.077.95
Field Groups /wp-admin/edit.php?post_type=acf-field-group1,3333.0347.0448.88

Uninstaller [IO: ▲0.00MB] [DB: ▲0.05MB] 50% from 4 tests

🔸 Tests weight: 35 | Verifying that this plugin uninstalls completely without leaving any traces
It is recommended to fix the following
  • Uninstall procedure had uncaught errors
    • > User notice in wp-includes/functions.php+5905
    Function acf_get_value was called incorrectly. Advanced Custom Fields - We've detected one or more calls to retrieve ACF field values before ACF has been initialized. This is not supported and can result in malformed or missing data. Learn how to fix this. Please see Debugging in WordPress for more information. (This message was added in version 5.11.1.)
  • Zombie WordPress options detected upon uninstall: 8 options
    • db_upgraded
    • widget_theysaidso_widget
    • can_compress_scripts
    • odsmm-content-default
    • widget_recent-comments
    • acf_version
    • widget_recent-posts
    • theysaidso_admin_options

Smoke tests 25% from 4 tests

Server-side errors 0% from 1 test

🔹 Test weight: 20 | This is a shallow check for server-side errors
These errors were triggered by the plugin
  • 14 occurences, only the last one shown
    • > GET request to /wp-admin/edit.php?post_type=acf-field-group
    • > POST request to /wp-admin/admin-ajax.php
    • > User notice in wp-includes/functions.php+5905
    Function acf_get_value was called incorrectly. Advanced Custom Fields - We've detected one or more calls to retrieve ACF field values before ACF has been initialized. This is not supported and can result in malformed or missing data. Learn how to fix this. Please see Debugging in WordPress for more information. (This message was added in version 5.11.1.)

SRP 50% from 2 tests

🔹 Tests weight: 20 | A shallow check of the single-responsibility principle; PHP files should perform no action - including output of placeholder text - and trigger no errors when accessed directly
The following issues need your attention
  • 90× GET requests to PHP files trigger server-side errors or Error 500 responses (only 10 are shown):
    • > PHP Fatal error
      Uncaught Error: Call to undefined function _e() in wp-content/plugins/oneds-start/includes/acf/includes/admin/views/html-admin-page-upgrade.php:26
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_action() in wp-content/plugins/oneds-start/includes/acf/includes/upgrades.php:455
    • > PHP Fatal error
      Uncaught Error: Class 'acf_field' not found in wp-content/plugins/oneds-start/includes/acf/includes/fields/class-acf-field-output.php:5
    • > PHP Fatal error
      Uncaught Error: Call to undefined function acf_add_filter_variations() in wp-content/plugins/oneds-start/includes/acf/includes/rest-api/acf-rest-api-functions.php:28
    • > PHP Notice
      Undefined variable: group_id in wp-content/plugins/oneds-start/includes/acf/includes/admin/views/html-location-group.php on line 3
    • > PHP Fatal error
      Uncaught Error: Class 'acf_field' not found in wp-content/plugins/oneds-start/includes/acf/includes/fields/class-acf-field-relationship.php:5
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_action() in wp-content/plugins/oneds-start/includes/admin-color-scheme.php:22
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_action() in wp-content/plugins/oneds-start/includes/oneds-options/includes/options-types/dashboard.php:36
    • > PHP Fatal error
      Uncaught Error: Class 'acf_field' not found in wp-content/plugins/oneds-start/includes/acf/includes/fields/class-acf-field-date_time_picker.php:5
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_filter() in wp-content/plugins/oneds-start/includes/acf/includes/acf-input-functions.php:103

User-side errors 0% from 1 test

🔹 Test weight: 20 | A shallow check that no browser errors were triggered
These are user-side errors you should fix
    • > GET request to /wp-admin/theme-options.php
    • > Network (severe)
    wp-admin/theme-options.php - Failed to load resource: the server responded with a status of 404 (Not Found)
    • > GET request to /wp-admin/dashboard-options.php
    • > Network (severe)
    wp-admin/dashboard-options.php - Failed to load resource: the server responded with a status of 404 (Not Found)
    • > GET request to /wp-admin/maintenance-mode-options.php
    • > Network (severe)
    wp-admin/maintenance-mode-options.php - Failed to load resource: the server responded with a status of 404 (Not Found)

Optimizations

Plugin configuration Passed 29 tests

readme.txt Passed 16 tests

The readme.txt file is important because it is parsed by WordPress.org for the public listing of your plugin
10 plugin tags: admin color scheme, admin widgets, maintenance mode, options pages, hello...

oneds-start/oneds-start.php Passed 13 tests

The primary PHP file in "OneDS Start Package" version 0.5 is used by WordPress to initiate all plugin functionality
18 characters long description:
Just Start Package

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | A short glimpse at programming languages used with this plugin and a check that no dangerous files are present
Success! There were no dangerous files found in this plugin116,581 lines of code in 225 files:
LanguageFilesBlank linesComment linesLines of code
PO File3224,17041,42349,433
JavaScript175,8905,98738,477
PHP1548,91818,60020,283
CSS211,0537498,382
SVG1006

PHP code Passed 2 tests

This is a very shot review of cyclomatic complexity and code structure
No cyclomatic complexity issues were detected for this plugin
Cyclomatic complexity
Average complexity per logical line of code0.37
Average class complexity14.74
▷ Minimum class complexity1.00
▷ Maximum class complexity78.00
Average method complexity2.87
▷ Minimum method complexity1.00
▷ Maximum method complexity24.00
Code structure
Namespaces0
Interfaces0
Traits0
Classes103
▷ Abstract classes21.94%
▷ Concrete classes10198.06%
▷ Final classes00.00%
Methods753
▷ Static methods10.13%
▷ Public methods73597.61%
▷ Protected methods00.00%
▷ Private methods182.39%
Functions492
▷ Named functions48999.39%
▷ Anonymous functions30.61%
Constants10
▷ Global constants10100.00%
▷ Class constants00.00%
▷ Public constants00.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

All PNG images should be compressed to minimize bandwidth usage for end users
7 compressed PNG files occupy 0.02MB
Potential savings
Compression of 5 random PNG files using pngquant
FileSize - originalSize - compressedSavings
includes/acf/assets/inc/datepicker/images/ui-icons_444444_256x240.png3.68KB4.17KB0.00%
includes/acf/assets/inc/select2/3/select2x2.png0.64KB0.77KB0.00%
includes/acf/assets/inc/select2/3/select2.png0.51KB0.99KB0.00%
includes/acf/assets/inc/datepicker/images/ui-bg_highlight-soft_0_ffffff_1x100.png0.08KB0.08KB0.00%
includes/acf/assets/inc/datepicker/images/ui-icons_ffffff_256x240.png3.68KB4.17KB0.00%