78% music-let-loose-mp3-audio-player

Code Review | MLL Audio Player MP3 Ajax

WordPress plugin MLL Audio Player MP3 Ajax scored78%from 54 tests.

About plugin

  • Plugin page: music-let-loose-m...
  • Plugin version: 0.7
  • PHP version: 7.4.16
  • WordPress compatibility: 3.4-4.7.2
  • WordPress version: 6.3.1
  • First release: Feb 6, 2017
  • Latest release: Feb 7, 2017
  • Number of updates: 3
  • Update frequency: N/A
  • Top authors: robert.kay (100%)

Code review

54 tests

User reviews

1 review

Install metrics

10+ active /3,088 total downloads

Benchmarks

Plugin footprint 83% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | Checking the installer triggered no errors
The plugin installed gracefully, with no errors

Server metrics [RAM: ▲0.23MB] [CPU: ▼7.11ms] Passed 4 tests

This is a short check of server-side resources used by MLL Audio Player MP3 Ajax
Normal server usage
PageMemory (MB)CPU Time (ms)
Home /3.67 ▲0.2125.89 ▼16.46
Dashboard /wp-admin3.54 ▲0.2445.37 ▼6.89
Posts /wp-admin/edit.php3.66 ▲0.3049.54 ▼2.46
Add New Post /wp-admin/post-new.php6.13 ▲0.2495.85 ▼2.62
Media Library /wp-admin/upload.php3.46 ▲0.2436.84 ▼1.66
Artists /wp-admin/edit.php?post_type=mllp_artist3.5141.04
Add New /wp-admin/post-new.php?post_type=mllp_song3.6750.94
MLL Player /wp-admin/options-general.php?page=MLLPlayer3.4129.81
Add New /wp-admin/post-new.php?post_type=mllp_artist3.6749.66
Albums /wp-admin/edit.php?post_type=mllp_album3.5137.39
Add New /wp-admin/post-new.php?post_type=mllp_album3.6750.65
Songs /wp-admin/edit.php?post_type=mllp_song3.5137.50

Server storage [IO: ▲0.40MB] [DB: ▲0.00MB] Passed 3 tests

Analyzing filesystem and database footprints of this plugin
No storage issues were detected
Filesystem: 22 new files
Database: no new tables, 7 new options
New WordPress options
theysaidso_admin_options
db_upgraded
widget_recent-comments
widget_recent-posts
can_compress_scripts
widget_mllp_widget
widget_theysaidso_widget

Browser metrics Passed 4 tests

MLL Audio Player MP3 Ajax: an overview of browser usage
This plugin has a minimal impact on browser resources
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,988 ▲25314.25 ▼0.0715.27 ▲13.5839.45 ▼3.09
Dashboard /wp-admin2,293 ▲1085.88 ▲0.07111.60 ▲12.5842.69 ▼1.73
Posts /wp-admin/edit.php2,180 ▲912.05 ▲0.0141.68 ▲4.0036.19 ▲3.81
Add New Post /wp-admin/post-new.php1,622 ▲10818.29 ▲0.76605.75 ▲12.3756.73 ▲3.17
Media Library /wp-admin/upload.php1,479 ▲914.23 ▲0.0898.16 ▼8.3445.07 ▲4.05
Artists /wp-admin/edit.php?post_type=mllp_artist1,1751.9734.0228.59
Add New /wp-admin/post-new.php?post_type=mllp_song2,5547.65178.0462.94
MLL Player /wp-admin/options-general.php?page=MLLPlayer9981.8325.4228.39
Add New /wp-admin/post-new.php?post_type=mllp_artist2,5057.61168.8955.67
Albums /wp-admin/edit.php?post_type=mllp_album1,1751.9532.8033.09
Add New /wp-admin/post-new.php?post_type=mllp_album2,5577.89156.2657.91
Songs /wp-admin/edit.php?post_type=mllp_song1,1751.9532.2630.31

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 75% from 4 tests

🔸 Tests weight: 35 | It is important to correctly uninstall your plugin, without leaving any traces
It is recommended to fix the following
  • Zombie WordPress options detected upon uninstall: 7 options
    • widget_mllp_widget
    • widget_recent-posts
    • widget_theysaidso_widget
    • db_upgraded
    • can_compress_scripts
    • theysaidso_admin_options
    • widget_recent-comments

Smoke tests 50% from 4 tests

Server-side errors 0% from 1 test

🔹 Test weight: 20 | A shallow check that no server-side errors were triggered
Please fix the following server-side errors
  • 12 occurences, only the last one shown
    • > GET request to /wp-admin/options-general.php?page=MLLPlayer
    • > Notice in wp-content/plugins/music-let-loose-mp3-audio-player/inc/mll-options.php+113
    Trying to access array offset on value of type bool

SRP 50% from 2 tests

🔹 Tests weight: 20 | SRP (Single-Responsibility Principle) - PHP files must act as libraries and never output text or perform any action when accessed directly in a browser
Please take a closer look at the following
  • 6× PHP files trigger server-side errors or warnings when accessed directly:
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_action() in wp-content/plugins/music-let-loose-mp3-audio-player/inc/mll-shortcodes.php:9
    • > PHP Fatal error
      Uncaught Error: Call to undefined function plugin_dir_url() in wp-content/plugins/music-let-loose-mp3-audio-player/mll-player.php:16
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_action() in wp-content/plugins/music-let-loose-mp3-audio-player/inc/mll-js-css-inc.php:9
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_action() in wp-content/plugins/music-let-loose-mp3-audio-player/inc/mll-options.php:4
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_action() in wp-content/plugins/music-let-loose-mp3-audio-player/inc/mll-controls.php:314
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_action() in wp-content/plugins/music-let-loose-mp3-audio-player/inc/mll-cpt.php:159

User-side errors Passed 1 test

🔹 Test weight: 20 | Just a short smoke test targeting errors on the browser (console and network errors and warnings)
Everything seems fine on the user side

Optimizations

Plugin configuration 93% from 29 tests

readme.txt 94% from 16 tests

Perhaps the most important file in your plugin readme.txt gets parsed in order to generate the public listing of your plugin
Please fix the following attributes:
  • Plugin Name: Please specify the plugin name on the first line ( === music-let-loose-mp3-audio-player === )
The official readme.txt is a good inspiration

music-let-loose-mp3-audio-player/mll-player.php 92% from 13 tests

Analyzing the main PHP file in "MLL Audio Player MP3 Ajax" version 0.7
It is important to fix the following:
  • Main file name: Even though not officially enforced, the main plugin file should be the same as the plugin slug ("music-let-loose-mp3-audio-player.php" instead of "mll-player.php")

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | A short check of programming languages and file extensions; no executable files are allowed
No dangerous file extensions were detected6,949 lines of code in 12 files:
LanguageFilesBlank linesComment linesLines of code
JavaScript51,6531,0525,725
PHP6159931,200
CSS11024

PHP code Passed 2 tests

Cyclomatic complexity and code structure are the fingerprint of this plugin
There were no cyclomatic complexity issued detected
Cyclomatic complexity
Average complexity per logical line of code0.20
Average class complexity4.00
▷ Minimum class complexity4.00
▷ Maximum class complexity4.00
Average method complexity1.75
▷ Minimum method complexity1.00
▷ Maximum method complexity2.00
Code structure
Namespaces0
Interfaces0
Traits0
Classes1
▷ Abstract classes00.00%
▷ Concrete classes1100.00%
▷ Final classes00.00%
Methods4
▷ Static methods00.00%
▷ Public methods4100.00%
▷ Protected methods00.00%
▷ Private methods00.00%
Functions76
▷ Named functions76100.00%
▷ Anonymous functions00.00%
Constants0
▷ Global constants00.00%
▷ Class constants00.00%
▷ Public constants00.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

Often times overlooked, PNG files can occupy unnecessary space in your plugin
4 PNG files occupy 0.00MB with 0.00MB in potential savings
Potential savings
Compression of 4 random PNG files using pngquant
FileSize - originalSize - compressedSavings
images/bck.png0.41KB0.27KB▼ 33.97%
images/play.png0.89KB0.70KB▼ 20.90%
images/pause.png0.79KB0.61KB▼ 23.71%
images/fwd.png0.41KB0.27KB▼ 33.49%