77% guild-armory-roster

Code Review | WoW Guild Armory Roster

WordPress plugin WoW Guild Armory Roster scored77%from 54 tests.

About plugin

  • Plugin page: guild-armory-roster
  • Plugin version: 0.5.5
  • PHP version: 7.4.16
  • WordPress compatibility: 3.0-4.7.4
  • WordPress version: 6.3.1
  • First release: Mar 1, 2016
  • Latest release: Apr 21, 2017
  • Number of updates: 25
  • Update frequency: every 16.6 days
  • Top authors: bchristopeit (100%)

Code review

54 tests

User reviews

1 review

Install metrics

20+ active /4,369 total downloads

Benchmarks

Plugin footprint 83% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | All plugins must install correctly, without throwing any errors, warnings, or notices
The plugin installed successfully, without throwing any errors or notices

Server metrics [RAM: ▲0.23MB] [CPU: ▼0.59ms] Passed 4 tests

This is a short check of server-side resources used by WoW Guild Armory Roster
No issues were detected with server-side resource usage
PageMemory (MB)CPU Time (ms)
Home /3.67 ▲0.2145.87 ▲4.51
Dashboard /wp-admin3.53 ▲0.2348.93 ▼9.43
Posts /wp-admin/edit.php3.64 ▲0.2952.42 ▲0.22
Add New Post /wp-admin/post-new.php6.13 ▲0.25105.64 ▲4.52
Media Library /wp-admin/upload.php3.45 ▲0.2339.91 ▲2.36
Settings /wp-admin/admin.php?page=wow-armory-table-options3.4041.17
WoW Armory Table /wp-admin/admin.php?page=wow-armory-table3.4533.95

Server storage [IO: ▲1.02MB] [DB: ▲0.00MB] Passed 3 tests

Analyzing filesystem and database footprints of this plugin
This plugin was installed successfully
Filesystem: 47 new files
Database: 4 new tables, 6 new options
New tables
wp_wow_armory_table_groups
wp_wow_armory_table_classes
wp_wow_armory_table_groups_mapping
wp_wow_armory_table_progress_mapping
New WordPress options
widget_theysaidso_widget
theysaidso_admin_options
can_compress_scripts
widget_recent-comments
db_upgraded
widget_recent-posts

Browser metrics Passed 4 tests

WoW Guild Armory Roster: an overview of browser usage
There were no issues detected in relation to browser resource usage
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,943 ▲15714.01 ▼0.2812.51 ▲10.6142.72 ▼1.88
Dashboard /wp-admin2,225 ▲455.73 ▲0.1588.94 ▼13.2079.52 ▲36.54
Posts /wp-admin/edit.php2,153 ▲532.31 ▲0.2937.37 ▼0.9335.14 ▼0.37
Add New Post /wp-admin/post-new.php1,564 ▲3823.08 ▲0.22718.35 ▲73.3640.04 ▼14.20
Media Library /wp-admin/upload.php1,439 ▲394.36 ▲0.18114.18 ▲10.5584.17 ▲39.06
Settings /wp-admin/admin.php?page=wow-armory-table-options3,2913.32117.7834.95
WoW Armory Table /wp-admin/admin.php?page=wow-armory-table1,1211.9228.9634.75

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 75% from 4 tests

🔸 Tests weight: 35 | Checking the uninstaller removed all traces of the plugin
These items require your attention
  • Zombie WordPress options were found after uninstall: 6 options
    • widget_recent-posts
    • theysaidso_admin_options
    • widget_theysaidso_widget
    • can_compress_scripts
    • widget_recent-comments
    • db_upgraded

Smoke tests 50% from 4 tests

Server-side errors 0% from 1 test

🔹 Test weight: 20 | A shallow check that no server-side errors were triggered
Smoke test failed, please fix the following
  • 20 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=wow-armory-table
    • > Notice in wp-content/plugins/guild-armory-roster/WoWArmoryTable.php+232
    Trying to access array offset on value of type bool

SRP 50% from 2 tests

🔹 Tests weight: 20 | SRP (Single-Responsibility Principle) - PHP files must act as libraries and never output text or perform any action when accessed directly in a browser
Please take a closer look at the following
  • 4× GET requests to PHP files have triggered server-side errors or warnings:
    • > PHP Warning
      Use of undefined constant ABSPATH - assumed 'ABSPATH' (this will throw an Error in a future version of PHP) in wp-content/plugins/guild-armory-roster/php/class.table.php on line 4
    • > PHP Fatal error
      Uncaught Error: Call to undefined function register_activation_hook() in wp-content/plugins/guild-armory-roster/WoWArmoryTable.php:20
    • > PHP Fatal error
      require_once(): Failed opening required 'ABSPATHwp-admin/includes/class-wp-list-table.php' (include_path='.:/usr/share/php') in wp-content/plugins/guild-armory-roster/php/class.table.php on line 4
    • > PHP Warning
      require_once(ABSPATHwp-admin/includes/class-wp-list-table.php): failed to open stream: No such file or directory in wp-content/plugins/guild-armory-roster/php/class.table.php on line 4

User-side errors Passed 1 test

🔹 Test weight: 20 | This is a smoke test targeting browser errors/issues
There were no browser issues found

Optimizations

Plugin configuration 87% from 29 tests

readme.txt 88% from 16 tests

The readme.txt file is undoubtedly the most important file in your plugin, preparing it for public listing on WordPress.org
These attributes need your attention:
  • Tags: You are using too many tags: 11 tag instead of maximum 10
  • Screenshots: Please add images for these screenshots: #1 (Frontend), #2 (Settings), #3 (Backend Table), #4 (Backend Buttons)
You can look at the official readme.txt

guild-armory-roster/WoWArmoryTable.php 85% from 13 tests

The main file in "WoW Guild Armory Roster" v. 0.5.5 serves as a complement to information provided in readme.txt and as the entry point to the plugin
It is important to fix the following:
  • Text Domain: Since WordPress version 4.6 the text domain is optional; if specified, it must be the same as the plugin slug
  • Main file name: Please rename the main PHP file in this plugin to the plugin slug ("guild-armory-roster.php" instead of "WoWArmoryTable.php")

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | An overview of files in this plugin; executable files are not allowed
Success! There were no dangerous files found in this plugin7,858 lines of code in 9 files:
LanguageFilesBlank linesComment linesLines of code
JavaScript21,9787,0046,291
PHP4284261,204
CSS24429208
PO File16773155

PHP code Passed 2 tests

An overview of cyclomatic complexity and code structure
Although this was not an exhaustive test, there were no cyclomatic complexity issues detected
Cyclomatic complexity
Average complexity per logical line of code0.28
Average class complexity37.50
▷ Minimum class complexity20.00
▷ Maximum class complexity62.00
Average method complexity3.62
▷ Minimum method complexity1.00
▷ Maximum method complexity22.00
Code structure
Namespaces0
Interfaces0
Traits0
Classes4
▷ Abstract classes00.00%
▷ Concrete classes4100.00%
▷ Final classes00.00%
Methods56
▷ Static methods00.00%
▷ Public methods5496.43%
▷ Protected methods00.00%
▷ Private methods23.57%
Functions0
▷ Named functions00.00%
▷ Anonymous functions00.00%
Constants0
▷ Global constants00.00%
▷ Class constants00.00%
▷ Public constants00.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

PNG files should be compressed to save space and minimize bandwidth usage
16 PNG files occupy 0.10MB with 0.06MB in potential savings
Potential savings
Compression of 5 random PNG files using pngquant
FileSize - originalSize - compressedSavings
icons/icons_normal.png36.59KB12.55KB▼ 65.71%
images/back_enabled.png1.35KB0.60KB▼ 55.69%
icons/wow_icon_16x16.png3.59KB1.10KB▼ 69.39%
icons/wow_icon_32x32.png5.67KB1.80KB▼ 68.25%
images/forward_enabled.png1.35KB0.58KB▼ 56.96%