72% filester

Code Review | File Manager Pro - Filester

WordPress plugin File Manager Pro - Filester scored72%from 54 tests.

About plugin

  • Plugin page: filester
  • Plugin version: 1.8.1
  • PHP version: 7.4.16
  • WordPress compatibility: 3.0-6.3.1
  • WordPress version: 6.3.1
  • First release: May 15, 2020
  • Latest release: Sep 12, 2023
  • Number of updates: 56
  • Update frequency: every 21.7 days
  • Top authors: ninjateam (100%)

Code review

54 tests

User reviews

113 reviews

Install metrics

50,000+ active /459,625 total downloads

Benchmarks

Plugin footprint 82% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | Verifying that this plugin installs correctly without errors
Install script ran successfully

Server metrics [RAM: ▲0.06MB] [CPU: ▼4.17ms] Passed 4 tests

An overview of server-side resources used by File Manager Pro - Filester
This plugin has minimal impact on server resources
PageMemory (MB)CPU Time (ms)
Home /3.54 ▲0.0839.46 ▼1.88
Dashboard /wp-admin3.36 ▲0.0649.91 ▼4.81
Posts /wp-admin/edit.php3.48 ▲0.1252.67 ▼1.79
Add New Post /wp-admin/post-new.php5.94 ▲0.0696.39 ▼8.19
Media Library /wp-admin/upload.php3.29 ▲0.0636.33 ▲0.40
Recommended Plugins /wp-admin/admin.php?page=filester_recommended_plugins3.2533.06
File Manager /wp-admin/admin.php?page=njt-fs-filemanager3.3136.34
Settings /wp-admin/admin.php?page=filester-settings3.3630.29

Server storage [IO: ▲5.95MB] [DB: ▲0.00MB] 67% from 3 tests

Analyzing filesystem and database footprints of this plugin
Please fix the following
  • Illegal file modification found: 1 file (0.00KB) outside of "wp-content/plugins/filester/" and "wp-content/uploads/"
    • (new file) .tmb/.empty
Filesystem: 314 new files
Database: no new tables, 13 new options
New WordPress options
njt_popup_filebird_cross
theysaidso_admin_options
njt_fs_first_time_active
njt_fs_review
njt_fs_settings
can_compress_scripts
njt_fs_version
db_upgraded
njt_fs_selector_themes
widget_recent-comments
...

Browser metrics Passed 4 tests

A check of browser resources used by File Manager Pro - Filester
There were no issues detected in relation to browser resource usage
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,908 ▲16213.23 ▼1.171.65 ▼0.1721.16 ▼24.22
Dashboard /wp-admin2,317 ▲1295.86 ▲0.94100.55 ▼4.6581.32 ▲37.23
Posts /wp-admin/edit.php2,123 ▲312.02 ▼0.0239.06 ▼5.9234.04 ▼2.95
Add New Post /wp-admin/post-new.php1,536 ▲317.74 ▼5.34606.38 ▼31.1063.63 ▲11.44
Media Library /wp-admin/upload.php1,433 ▲454.33 ▲0.0397.71 ▼7.2044.22 ▲1.00
Recommended Plugins /wp-admin/admin.php?page=filester_recommended_plugins1,1032.3733.4231.30
File Manager /wp-admin/admin.php?page=njt-fs-filemanager4,2934.93216.5686.02
Settings /wp-admin/admin.php?page=filester-settings1,7753.0567.6872.02

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 75% from 4 tests

🔸 Tests weight: 35 | The uninstall procedure must remove all plugin files and extra database tables
You still need to fix the following
  • Zombie WordPress options detected upon uninstall: 13 options
    • njt_popup_filebird_cross
    • widget_theysaidso_widget
    • db_upgraded
    • theysaidso_admin_options
    • njt_fs_selector_themes
    • njt_fs_review
    • widget_recent-posts
    • njt_fs_settings
    • can_compress_scripts
    • njt_notification_filebird_cross
    • ...

Smoke tests 25% from 4 tests

Server-side errors Passed 1 test

🔹 Test weight: 20 | A smoke test targeting server-side errors
Even though everything seems fine, this is not an exhaustive test

SRP 0% from 2 tests

🔹 Tests weight: 20 | The single-responsibility principle applies for WordPress plugins as well - please make sure your PHP files perform no actions when accessed directly
Almost there! Just fix the following items
  • 1× GET requests to PHP files return non-empty strings:
    • > /wp-content/plugins/filester/views/pages/html-filemanager-list-operations.php
  • 24× PHP files trigger server errors when accessed directly (only 10 are shown):
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderPlugin' not found in wp-content/plugins/filester/includes/File_manager/lib/php/plugins/Watermark/plugin.php:70
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderEditor' not found in wp-content/plugins/filester/includes/File_manager/lib/php/editors/OnlineConvert/editor.php:3
    • > PHP Fatal error
      Uncaught Error: Class 'elFinder' not found in wp-content/plugins/filester/includes/File_manager/lib/php/elFinderFlysystemGoogleDriveNetmount.php:12
    • > PHP Fatal error
      Uncaught Error: Interface 'elFinderSessionInterface' not found in wp-content/plugins/filester/includes/File_manager/lib/php/elFinderSession.php:11
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderVolumeFTP' not found in wp-content/plugins/filester/includes/File_manager/lib/php/elFinderVolumeSFTPphpseclib.class.php:10
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderVolumeMySQL' not found in wp-content/plugins/filester/includes/File_manager/lib/php/elFinderVolumeTrashMySQL.class.php:8
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderVolumeDriver' not found in wp-content/plugins/filester/includes/File_manager/lib/php/elFinderVolumeMySQL.class.php:8
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderVolumeDriver' not found in wp-content/plugins/filester/includes/File_manager/lib/php/elFinderVolumeOneDrive.class.php:10
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderEditor' not found in wp-content/plugins/filester/includes/File_manager/lib/php/editors/ZipArchive/editor.php:3
    • > PHP Fatal error
      Uncaught Error: Class 'elFinderPlugin' not found in wp-content/plugins/filester/includes/File_manager/lib/php/plugins/Normalizer/plugin.php:55

User-side errors 0% from 1 test

🔹 Test weight: 20 | This is just a short smoke test looking for browser issues
Please fix the following browser errors
    • > GET request to /wp-admin/admin.php?page=njt-fs-filemanager
    • > Network (severe)
    wp-content/plugins/filester/includes/File_manager/lib/js/i18n/elfinder..js - Failed to load resource: the server responded with a status of 404 (Not Found)

Optimizations

Plugin configuration 96% from 29 tests

readme.txt Passed 16 tests

The readme.txt file uses markdown syntax to describe your plugin to the world
7 plugin tags: file manager, document management, wp media manager, real media library, wp file manager...

filester/ninja-file-manager.php 92% from 13 tests

The main PHP file in "File Manager Pro - Filester" ver. 1.8.1 adds more information about the plugin and also serves as the entry point for this plugin
It is important to fix the following:
  • Main file name: Please rename the main PHP file in this plugin to the plugin slug ("filester.php" instead of "ninja-file-manager.php")

Code Analysis 95% from 3 tests

File types Passed 1 test

🔸 Test weight: 35 | This is an overview of file extensions present in this plugin and a short test that no dangerous files are bundled with this plugin
Everything looks great! No dangerous files found in this plugin85,438 lines of code in 177 files:
LanguageFilesBlank linesComment linesLines of code
JavaScript653,3856,01549,446
PHP443,2999,37120,894
CSS221,13790112,533
SVG209301,182
LESS14147117792
Markdown5580231
HTML21219133
PO File14182103
JSON30080
SQL13044

PHP code 0% from 2 tests

An overview of cyclomatic complexity and code structure
It is recommended to fix the following
  • Cyclomatic complexity of classes should be reduced to less than 1000 (currently 1,401)
  • Please reduce cyclomatic complexity of methods to less than 100 (currently 150)
Cyclomatic complexity
Average complexity per logical line of code0.64
Average class complexity129.27
▷ Minimum class complexity1.00
▷ Maximum class complexity1,401.00
Average method complexity7.18
▷ Minimum method complexity1.00
▷ Maximum method complexity150.00
Code structure
Namespaces2
Interfaces1
Traits0
Classes40
▷ Abstract classes12.50%
▷ Concrete classes3997.50%
▷ Final classes00.00%
Methods885
▷ Static methods535.99%
▷ Public methods28131.75%
▷ Protected methods58065.54%
▷ Private methods242.71%
Functions6
▷ Named functions350.00%
▷ Anonymous functions350.00%
Constants102
▷ Global constants2524.51%
▷ Class constants7775.49%
▷ Public constants77100.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

Often times overlooked, PNG files can occupy unnecessary space in your plugin
89 compressed PNG files occupy 0.13MB
Potential savings
Compression of 5 random PNG files using pngquant
FileSize - originalSize - compressedSavings
includes/File_manager/lib/jquery/images/ui-icons_555555_256x240.png6.91KB4.18KB▼ 39.47%
includes/File_manager/lib/themes/windows-10/images/16px/download.png0.37KB0.39KB0.00%
includes/File_manager/lib/img/icons-small.png3.59KB3.68KB0.00%
includes/File_manager/lib/themes/windows-10/images/16px/extract.png0.47KB0.55KB0.00%
includes/File_manager/lib/img/toolbar.png7.33KB7.62KB0.00%