78% e20r-members-list

Code Review | E20R Better Members List for Paid Memberships Pro

WordPress plugin E20R Better Members List for Paid Memberships Pro scored78%from 54 tests.

About plugin

  • Plugin page: e20r-members-list
  • Plugin version: 8.6
  • PHP compatiblity: 7.1+
  • PHP version: 7.4.16
  • WordPress compatibility: 4.9-5.9.2
  • WordPress version: 6.3.1
  • First release: Nov 11, 2018
  • Latest release: Mar 27, 2022
  • Number of updates: 59
  • Update frequency: every 20.9 days
  • Top authors: eighty20results (100%)

Code review

54 tests

User reviews

3 reviews

Install metrics

30+ active /7,926 total downloads

Benchmarks

Plugin footprint 83% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | Verifying that this plugin installs correctly without errors
Installer ran successfully

Server metrics [RAM: ▲0.29MB] [CPU: ▼4.57ms] Passed 4 tests

A check of server-side resources used by E20R Better Members List for Paid Memberships Pro
This plugin has minimal impact on server resources
PageMemory (MB)CPU Time (ms)
Home /3.79 ▲0.3343.96 ▲1.35
Dashboard /wp-admin3.64 ▲0.2948.73 ▼18.05
Posts /wp-admin/edit.php3.69 ▲0.3350.84 ▲4.55
Add New Post /wp-admin/post-new.php6.16 ▲0.27101.54 ▼3.78
Media Library /wp-admin/upload.php3.50 ▲0.2739.09 ▲2.22

Server storage [IO: ▲0.27MB] [DB: ▲0.00MB] Passed 3 tests

Input-output and database impact of this plugin
This plugin was installed successfully
Filesystem: 26 new files
Database: no new tables, 6 new options
New WordPress options
widget_recent-comments
widget_recent-posts
theysaidso_admin_options
db_upgraded
widget_theysaidso_widget
can_compress_scripts

Browser metrics Passed 4 tests

Checking browser requirements for E20R Better Members List for Paid Memberships Pro
Minimal impact on browser resources
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,826 ▲8013.38 ▼1.381.96 ▲0.1542.35 ▼0.63
Dashboard /wp-admin2,235 ▲504.86 ▼0.03103.84 ▼14.9141.99 ▼1.51
Posts /wp-admin/edit.php2,114 ▲282.13 ▲0.1042.35 ▲4.6039.05 ▲5.94
Add New Post /wp-admin/post-new.php1,559 ▲4023.39 ▲0.32662.39 ▼9.1353.56 ▲2.09
Media Library /wp-admin/upload.php1,408 ▲204.28 ▲0.0997.84 ▼4.9242.27 ▼0.60

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 75% from 4 tests

🔸 Tests weight: 35 | Verifying that this plugin uninstalls completely without leaving any traces
The following items require your attention
  • Zombie WordPress options were found after uninstall: 6 options
    • widget_recent-comments
    • can_compress_scripts
    • widget_theysaidso_widget
    • db_upgraded
    • theysaidso_admin_options
    • widget_recent-posts

Smoke tests 50% from 4 tests

Server-side errors Passed 1 test

🔹 Test weight: 20 | This is a shallow check for server-side errors
Good news, no errors were detected

SRP 0% from 2 tests

🔹 Tests weight: 20 | It is important to ensure that your PHP files perform no action when accessed directly, respecting the single-responsibility principle
Almost there! Just fix the following items
  • 12× PHP files output non-empty strings when accessed directly via GET requests (only 10 are shown):
    • > /wp-content/plugins/e20r-members-list/src/E20R/members-list/admin/bulk/Bulk_Update.php
    • > /wp-content/plugins/e20r-members-list/src/E20R/members-list/modules/Multiple_Memberships.php
    • > /wp-content/plugins/e20r-members-list/inc/mixpanel/mixpanel-php/examples/custom_consumer.php
    • > /wp-content/plugins/e20r-members-list/src/E20R/members-list/admin/bulk/Bulk_Operations.php
    • > /wp-content/plugins/e20r-members-list/class-e20r-members-list.php
    • > /wp-content/plugins/e20r-members-list/ActivateUtilitiesPlugin.php
    • > /wp-content/plugins/e20r-members-list/src/E20R/members-list/admin/pages/Members_List_Page.php
    • > /wp-content/plugins/e20r-members-list/src/E20R/members-list/admin/export/Export_Members.php
    • > /wp-content/plugins/e20r-members-list/src/E20R/members-list/admin/bulk/Bulk_Cancel.php
    • > /wp-content/plugins/e20r-members-list/src/E20R/members-list/Members_List.php
  • 127× PHP files trigger server-side errors or warnings when accessed directly (only 10 are shown):
    • > [ Base_MixpanelBase - line 94 ]
      destruct flush attempt #1
    • > [ Base_MixpanelBase - line 94 ]
      destruct flush attempt #7
    • > PHP Warning
      require_once(/path/to/vendor/mixpanel/mixpanel-php/lib/Mixpanel.php): failed to open stream: No such file or directory in wp-content/plugins/e20r-members-list/inc/mixpanel/mixpanel-php/examples/all_calls.php on line 2
    • > [ ObConsumer - line 8 ]
      This is the data from a fake error
    • > [ Base_MixpanelBase - line 123 ]
      Batch consumption failed!
    • > [ Base_MixpanelBase - line 76 ]
      Using token: MIXPANEL_PROJECT_TOKEN
    • > [ Base_MixpanelBase - line 141 ]
      Creating new socket at 1696724796
    • > [ Base_MixpanelBase - line 94 ]
      destruct flush attempt #1
    • > [ Base_MixpanelBase - line 18 ]
      Instantiated new Consumer
    • > [ ObConsumer - line 8 ]
      This is the data from a fake error

User-side errors Passed 1 test

🔹 Test weight: 20 | This is just a short smoke test looking for browser issues
Everything seems fine on the user side

Optimizations

Plugin configuration 96% from 29 tests

readme.txt Passed 16 tests

Often overlooked, readme.txt is one of the most important files in your plugin
7 plugin tags: paid memberships pro, members, memberships, pmpro enhancements, better members list...

e20r-members-list/class-e20r-members-list.php 92% from 13 tests

The main PHP file in "E20R Better Members List for Paid Memberships Pro" ver. 8.6 adds more information about the plugin and also serves as the entry point for this plugin
Please take the time to fix the following:
  • Main file name: Even though not officially enforced, the main plugin file should be the same as the plugin slug ("e20r-members-list.php" instead of "class-e20r-members-list.php")

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | A short glimpse at programming languages used with this plugin and a check that no dangerous files are present
Success! There were no dangerous files found in this plugin22,468 lines of code in 123 files:
LanguageFilesBlank linesComment linesLines of code
HTML241,63316810,659
PHP581,4823,4036,031
CSS7109431,863
JavaScript133384721,770
SVG8424971
Markdown62350918
JSON300171
YAML28944
XML23041

PHP code Passed 2 tests

This is a very shot review of cyclomatic complexity and code structure
There are no cyclomatic complexity problems detected for this plugin
Cyclomatic complexity
Average complexity per logical line of code0.37
Average class complexity17.22
▷ Minimum class complexity1.00
▷ Maximum class complexity183.00
Average method complexity3.30
▷ Minimum method complexity1.00
▷ Maximum method complexity37.00
Code structure
Namespaces10
Interfaces0
Traits0
Classes45
▷ Abstract classes36.67%
▷ Concrete classes4293.33%
▷ Final classes00.00%
Methods328
▷ Static methods3911.89%
▷ Public methods27082.32%
▷ Protected methods257.62%
▷ Private methods3310.06%
Functions10
▷ Named functions330.00%
▷ Anonymous functions770.00%
Constants6
▷ Global constants233.33%
▷ Class constants466.67%
▷ Public constants4100.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

Using a strong compression for your PNG files is a great way to speed-up your plugin
13 PNG files occupy 0.06MB with 0.02MB in potential savings
Potential savings
Compression of 5 random PNG files using pngquant
FileSize - originalSize - compressedSavings
inc/mixpanel/mixpanel-php/docs/images/icon-interface-13x13.png0.30KB0.19KB▼ 37.99%
inc/mixpanel/mixpanel-php/docs/images/apple-touch-icon-72x72.png12.45KB5.26KB▼ 57.74%
inc/mixpanel/mixpanel-php/docs/images/apple-touch-icon.png8.16KB3.82KB▼ 53.23%
inc/mixpanel/mixpanel-php/docs/images/iviewer/iviewer.rotate_left.png1.46KB1.47KB0.00%
inc/mixpanel/mixpanel-php/docs/images/iviewer/iviewer.zoom_out.png1.38KB0.51KB▼ 63.42%