71% dsgvo-all-in-one-for-wp

Code Review | DSGVO All in one for WP

WordPress plugin DSGVO All in one for WP scored71%from 54 tests.

About plugin

  • Plugin page: dsgvo-all-in-one-...
  • Plugin version: 4.3
  • PHP version: 7.4.16
  • WordPress compatibility: 4.0-6.0
  • WordPress version: 6.3.1
  • First release: Jun 12, 2018
  • Latest release: Sep 28, 2022
  • Number of updates: 270
  • Update frequency: every 5.8 days
  • Top authors: mlfactory (100%)

Code review

54 tests

User reviews

146 reviews

Install metrics

20,000+ active /243,241 total downloads

Benchmarks

Plugin footprint 83% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | Checking the installer triggered no errors
Installer ran successfully

Server metrics [RAM: ▲0.78MB] [CPU: ▲2.07ms] Passed 4 tests

A check of server-side resources used by DSGVO All in one for WP
This plugin does not affect your website's performance
PageMemory (MB)CPU Time (ms)
Home /4.13 ▲0.6742.72 ▲5.84
Dashboard /wp-admin4.26 ▲0.9154.56 ▼4.91
Posts /wp-admin/edit.php4.26 ▲0.9069.34 ▲22.69
Add New Post /wp-admin/post-new.php6.53 ▲0.6595.35 ▼6.91
Media Library /wp-admin/upload.php4.26 ▲1.0348.28 ▲14.24
Import / Export /wp-admin/admin.php?page=dsgvoaio-free-import-export4.2640.19
DSGVO AIO /wp-admin/admin.php?page=dsgvoaio-free-settings-page5.8083.50
Opt-in/Opt-out Log /wp-admin/admin.php?page=dsgvoaiofree-show-log4.2646.78
Changelog 1 /wp-admin/admin.php?page=dsgvoaiofree-changelog4.2641.07

Server storage [IO: ▲2.26MB] [DB: ▲0.02MB] Passed 3 tests

Analyzing filesystem and database footprints of this plugin
This plugin installed successfully
Filesystem: 100 new files
Database: no new tables, 7 new options
New WordPress options
widget_recent-posts
widget_recent-comments
widget_theysaidso_widget
dsgvoaio_notification_count_v42
can_compress_scripts
db_upgraded
theysaidso_admin_options

Browser metrics Passed 4 tests

DSGVO All in one for WP: an overview of browser usage
This plugin has a minimal impact on browser resources
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,944 ▲19820.62 ▲6.251.58 ▼0.0941.62 ▼2.34
Dashboard /wp-admin2,347 ▲15910.96 ▲5.08256.96 ▲145.4642.18 ▲0.55
Posts /wp-admin/edit.php2,229 ▲1409.52 ▲7.4692.88 ▲52.1336.78 ▲0.47
Add New Post /wp-admin/post-new.php6,395 ▲4,88128.38 ▲10.91782.49 ▲94.4739.19 ▼5.97
Media Library /wp-admin/upload.php1,550 ▲16212.20 ▲8.00136.15 ▲25.9142.01 ▼5.19
Import / Export /wp-admin/admin.php?page=dsgvoaio-free-import-export9989.4780.3230.63
DSGVO AIO /wp-admin/admin.php?page=dsgvoaio-free-settings-page5,20015.98332.0558.86
Opt-in/Opt-out Log /wp-admin/admin.php?page=dsgvoaiofree-show-log9349.5272.4325.42
Changelog 1 /wp-admin/admin.php?page=dsgvoaiofree-changelog1,3779.4787.8927.96

Uninstaller [IO: ▲0.00MB] [DB: ▲0.01MB] 75% from 4 tests

🔸 Tests weight: 35 | It is important to correctly uninstall your plugin, without leaving any traces
These items require your attention
  • Zombie WordPress options were found after uninstall: 7 options
    • dsgvoaio_notification_count_v42
    • widget_recent-posts
    • widget_recent-comments
    • widget_theysaidso_widget
    • db_upgraded
    • theysaidso_admin_options
    • can_compress_scripts

Smoke tests 25% from 4 tests

Server-side errors 0% from 1 test

🔹 Test weight: 20 | Just a short smoke test targeting errors on the server (in the Apache logs)
Smoke test failed, please fix the following
    • > GET request to /wp-admin/admin.php?page=dsgvoaio-free-import-export
    • > User deprecated in wp-includes/functions.php+5463
    Function screen_icon is deprecated since version 3.8.0 with no alternative available.
    • > GET request to /wp-admin/admin.php?page=dsgvoaio-free-import-export
    • > User deprecated in wp-includes/functions.php+5463
    Function get_screen_icon is deprecated since version 3.8.0 with no alternative available.

SRP 0% from 2 tests

🔹 Tests weight: 20 | It is important to ensure that your PHP files perform no action when accessed directly, respecting the single-responsibility principle
The following issues need your attention
  • 1× PHP files perform the task of outputting text when accessed with GET requests:
    • > /wp-content/plugins/dsgvo-all-in-one-for-wp/core/inc/backend_settings.php
  • 3× GET requests to PHP files have triggered server-side errors or warnings:
    • > PHP Fatal error
      Uncaught Error: Call to undefined function get_userdata() in wp-content/plugins/dsgvo-all-in-one-for-wp/core/inc/user_remove_form.php:2
    • > PHP Fatal error
      Uncaught Error: Call to undefined function get_option() in wp-content/plugins/dsgvo-all-in-one-for-wp/core/inc/exporter_fetch_datas.php:3
    • > PHP Fatal error
      Uncaught Error: Call to undefined function get_option() in wp-content/plugins/dsgvo-all-in-one-for-wp/core/inc/imprint.php:4

User-side errors Passed 1 test

🔹 Test weight: 20 | This is a shallow check for browser errors
Everything seems fine on the user side

Optimizations

Plugin configuration 83% from 29 tests

readme.txt 81% from 16 tests

It's important to format your readme.txt file correctly as it is parsed for the public listing of your plugin
Attributes that need to be fixed:
  • Screenshots: Please add images for these screenshots: #10 (Beispiel der simplen Shortcodes zum einbinden der externen Services), #11 (Übersicht Backend Plugin Einstellungen), #12 (Übersicht Backend Plugin Einstellungen), #13 (Übersicht Backend Plugin Einstellungen (Externe Services)), #14 (Cookie Notice Einstellungen)
  • Requires at least: Invalid plugin version format
  • Requires php: Invalid plugin version format
The official readme.txt might help

dsgvo-all-in-one-for-wp/dsgvo_all_in_one_wp.php 85% from 13 tests

The primary PHP file in "DSGVO All in one for WP" version 4.3 is used by WordPress to initiate all plugin functionality
Please take the time to fix the following:
  • Description: Please keep the plugin description shorter than 140 characters (currently 161 characters long)
  • Main file name: Name the main plugin file the same as the plugin slug ("dsgvo-all-in-one-for-wp.php" instead of "dsgvo_all_in_one_wp.php")

Code Analysis 97% from 3 tests

File types Passed 1 test

🔸 Test weight: 35 | This is an overview of file extensions present in this plugin and a short test that no dangerous files are bundled with this plugin
Success! There were no dangerous files found in this plugin26,996 lines of code in 58 files:
LanguageFilesBlank linesComment linesLines of code
PHP303,51136513,085
PO File53,1494,5158,299
JavaScript16255394,697
CSS616720892
JSON12023

PHP code 50% from 2 tests

This is a short overview of cyclomatic complexity and code structure for this plugin
Please tend to the following items
  • Cyclomatic complexity of methods has to be reduced to less than 100 (currently 151)
Cyclomatic complexity
Average complexity per logical line of code0.46
Average class complexity193.67
▷ Minimum class complexity14.00
▷ Maximum class complexity542.00
Average method complexity6.61
▷ Minimum method complexity1.00
▷ Maximum method complexity151.00
Code structure
Namespaces0
Interfaces0
Traits0
Classes6
▷ Abstract classes00.00%
▷ Concrete classes6100.00%
▷ Final classes00.00%
Methods204
▷ Static methods7134.80%
▷ Public methods16681.37%
▷ Protected methods3818.63%
▷ Private methods00.00%
Functions26
▷ Named functions26100.00%
▷ Anonymous functions00.00%
Constants1
▷ Global constants1100.00%
▷ Class constants00.00%
▷ Public constants00.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

Often times overlooked, PNG files can occupy unnecessary space in your plugin
15 PNG files occupy 0.11MB with 0.03MB in potential savings
Potential savings
Compression of 5 random PNG files using pngquant
FileSize - originalSize - compressedSavings
assets/img/twitter.png0.72KB0.51KB▼ 29.21%
assets/css/DataTables-1.10.20/images/sort_both.png0.20KB0.29KB0.00%
assets/img/dsgvo_free_logo.png7.45KB4.60KB▼ 38.25%
assets/img/service_control.png21.36KB12.08KB▼ 43.43%
assets/img/fbcomments.png4.98KB2.92KB▼ 41.23%