10% custom-login-page

Code Review | A5 Custom Login Page

WordPress plugin A5 Custom Login Page scored10%from 54 tests.

About plugin

  • Plugin page: custom-login-page
  • Plugin version: 2.8.1
  • PHP version: 7.4.16
  • WordPress compatibility: 3.9-4.5
  • WordPress version: 6.3.1
  • First release: Dec 17, 2011
  • Latest release: Feb 26, 2016
  • Number of updates: 90
  • Update frequency: every 17.1 days
  • Top authors: tepelstreel (100%)

Code review

54 tests

User reviews

24 reviews

Install metrics

1,000+ active /133,244 total downloads

Benchmarks

Plugin footprint 40% from 16 tests

Installer 0% from 1 test

🔺 Critical test (weight: 50) | Verifying that this plugin installs correctly without errors
These installer errors require your attention
  • This plugin did not install gracefully
    • > Deprecated in wp-content/plugins/custom-login-page/class-lib/CLP_WidgetClass.php+233
    Function create_function() is deprecated

Server metrics [RAM: ▲0.96MB] [CPU: ▼45.06ms] Passed 4 tests

This is a short check of server-side resources used by A5 Custom Login Page
This plugin has minimal impact on server resources
PageMemory (MB)CPU Time (ms)
Home /4.95 ▲1.4816.48 ▼29.19
Dashboard /wp-admin4.97 ▲1.6622.11 ▼30.21
Posts /wp-admin/edit.php4.97 ▲1.6116.97 ▼38.06
Add New Post /wp-admin/post-new.php4.97 ▼0.9217.90 ▼82.76
Media Library /wp-admin/upload.php4.97 ▲1.7426.16 ▼11.92
Custom Login Shortcode /wp-admin/admin.php?page=clp-shortcode-settings4.9718.14
Custom Login Page /wp-admin/admin.php?page=clp-settings4.9723.73
Custom Login Widget /wp-admin/admin.php?page=clp-widget-settings4.9719.69

Server storage [IO: ▲0.89MB] [DB: ▲0.00MB] Passed 3 tests

A short overview of filesystem and database impact
No storage issues were detected
Filesystem: 39 new files
Database: no new tables, 10 new options
New WordPress options
db_upgraded
clp_shortcode_options
clp_widget_options
theysaidso_admin_options
clp_options
widget_theysaidso_widget
widget_recent-comments
can_compress_scripts
widget_custom_login_widget
widget_recent-posts

Browser metrics Passed 4 tests

This is an overview of browser requirements for A5 Custom Login Page
Minimal impact on browser resources
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,852 ▲9114.57 ▲0.001.87 ▼0.0143.75 ▼2.61
Dashboard /wp-admin2,241 ▲705.58 ▼0.0986.34 ▼12.0578.97 ▲35.27
Posts /wp-admin/edit.php2,149 ▲492.00 ▲0.0037.65 ▼2.9335.11 ▼0.93
Add New Post /wp-admin/post-new.php1,721 ▲19521.54 ▼1.41759.27 ▲62.7256.99 ▼4.42
Media Library /wp-admin/upload.php1,449 ▲524.12 ▼0.08102.87 ▼14.8975.17 ▲26.30
Custom Login Shortcode /wp-admin/admin.php?page=clp-shortcode-settings1,5875.7976.67102.55
Custom Login Page /wp-admin/admin.php?page=clp-settings1,4725.7970.4776.73
Custom Login Widget /wp-admin/admin.php?page=clp-widget-settings1,5975.8069.9397.74

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 50% from 4 tests

🔸 Tests weight: 35 | Checking the uninstaller removed all traces of the plugin
You still need to fix the following
  • Uninstall procedure validation failed for this plugin
    • > Deprecated in wp-content/plugins/custom-login-page/class-lib/CLP_WidgetClass.php+233
    Function create_function() is deprecated
  • The uninstall procedure has failed, leaving 7 options in the database
    • widget_custom_login_widget
    • theysaidso_admin_options
    • widget_recent-posts
    • can_compress_scripts
    • widget_recent-comments
    • widget_theysaidso_widget
    • db_upgraded

Smoke tests 25% from 4 tests

Server-side errors 0% from 1 test

🔹 Test weight: 20 | A smoke test targeting server-side errors
Almost there, just fix the following server-side errors
  • 3 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Deprecated in wp-content/plugins/custom-login-page/class-lib/CLP_WidgetClass.php+233
    Function create_function() is deprecated
  • 24 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/custom-login-page.php+175
    Undefined index: multisite
  • 6 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_ShortcodeClass.php+19
    Undefined index: login_form_top
  • 6 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_ShortcodeClass.php+20
    Undefined index: login_form
  • 6 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_ShortcodeClass.php+21
    Undefined index: login_form_bottom
  • 3 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > User deprecated in wp-includes/functions.php+5828
    Hook contextual_help is deprecated since version 3.3.0! Use get_current_screen()->add_help_tab(), get_current_screen()->remove_help_tab() instead.
  • 3 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+1261
    Undefined index: action
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+416
    Undefined index: label_username
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+422
    Undefined index: label_password
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+428
    Undefined index: label_remember
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+434
    Undefined index: label_log_in
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+440
    Undefined index: hide_remember
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+446
    Undefined index: value_remember
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+464
    Undefined index: redirect
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+472
    Undefined index: form_id
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+478
    Undefined index: id_username
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+484
    Undefined index: id_password
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+490
    Undefined index: id_remember
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+496
    Undefined index: id_submit
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php+502
    Undefined index: value_username
    • > GET request to /wp-admin/admin.php?page=clp-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClass.php+535
    Undefined index: logout_custom_message
    • > GET request to /wp-admin/admin.php?page=clp-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClass.php+541
    Undefined index: error_custom_message
    • > GET request to /wp-admin/admin.php?page=clp-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClass.php+553
    Undefined index: register_custom_message
    • > GET request to /wp-admin/admin.php?page=clp-settings
    • > Notice in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClass.php+547
    Undefined index: password_custom_message

SRP 50% from 2 tests

🔹 Tests weight: 20 | The single-responsibility principle applies for WordPress plugins as well - please make sure your PHP files perform no actions when accessed directly
Almost there! Just fix the following items
  • 7× GET requests to PHP files trigger server-side errors or Error 500 responses:
    • > PHP Fatal error
      Uncaught Error: Class 'A5_DynamicFiles' not found in wp-content/plugins/custom-login-page/class-lib/CLP_DynamicCSSClass.php:13
    • > PHP Fatal error
      Uncaught Error: Class 'A5_OptionPage' not found in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassWidget.php:12
    • > PHP Fatal error
      Uncaught Error: Class 'A5_Widget' not found in wp-content/plugins/custom-login-page/class-lib/CLP_WidgetClass.php:12
    • > PHP Fatal error
      Uncaught Error: Class 'WP_Widget' not found in wp-content/plugins/custom-login-page/class-lib/A5_WidgetClass.php:14
    • > PHP Fatal error
      Uncaught Error: Class 'A5_DynamicFiles' not found in wp-content/plugins/custom-login-page/class-lib/CLP_DynamicJSClass.php:13
    • > PHP Fatal error
      Uncaught Error: Class 'A5_OptionPage' not found in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClassShortcode.php:12
    • > PHP Fatal error
      Uncaught Error: Class 'A5_OptionPage' not found in wp-content/plugins/custom-login-page/class-lib/CLP_AdminClass.php:12

User-side errors 0% from 1 test

🔹 Test weight: 20 | Just a short smoke test targeting errors on the browser (console and network errors and warnings)
There are user-side issues you should fix
  • 2 occurences, only the last one shown
    • > GET request to /wp-admin/admin.php?page=clp-widget-settings
    • > Network (severe)
    https://button.flattr.com/flattr-badge-large.png - Failed to load resource: the server responded with a status of 404 ()

Optimizations

Plugin configuration 93% from 29 tests

readme.txt 94% from 16 tests

You should put a lot of thought into formatting readme.txt as it is used by WordPress.org to prepare the public listing of your plugin
Attributes that need to be fixed:
  • Tags: You are using too many tags: 14 tag instead of maximum 10
You can take inspiration from this readme.txt

custom-login-page/custom-login-page.php 92% from 13 tests

"A5 Custom Login Page" version 2.8.1's main PHP file describes plugin functionality and also serves as the entry point to any WordPress functionality
It is important to fix the following:
  • Description: The description should be shorter than 140 characters (currently 160 characters long)

Code Analysis 97% from 3 tests

File types Passed 1 test

🔸 Test weight: 35 | This is a short overview of programming languages used in this plugin, detecting executable files
Good job! No executable or dangerous file extensions detected9,089 lines of code in 27 files:
LanguageFilesBlank linesComment linesLines of code
PHP134,0528535,197
PO File41,0602,1553,597
JavaScript1012958295

PHP code 50% from 2 tests

An short overview of logical lines of code, cyclomatic complexity, and other code metrics
Please tend to the following items
  • Method cyclomatic complexity should be reduced to less than 100 (currently 329)
Cyclomatic complexity
Average complexity per logical line of code0.28
Average class complexity70.46
▷ Minimum class complexity1.00
▷ Maximum class complexity330.00
Average method complexity2.72
▷ Minimum method complexity1.00
▷ Maximum method complexity329.00
Code structure
Namespaces0
Interfaces0
Traits0
Classes13
▷ Abstract classes00.00%
▷ Concrete classes13100.00%
▷ Final classes00.00%
Methods525
▷ Static methods264.95%
▷ Public methods51898.67%
▷ Protected methods00.00%
▷ Private methods71.33%
Functions29
▷ Named functions29100.00%
▷ Anonymous functions00.00%
Constants5
▷ Global constants240.00%
▷ Class constants360.00%
▷ Public constants3100.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

All PNG images should be compressed to minimize bandwidth usage for end users
4 PNG files occupy 0.01MB with 0.00MB in potential savings
Potential savings
Compression of 4 random PNG files using pngquant
FileSize - originalSize - compressedSavings
img/a5-icon-16.png0.77KB0.57KB▼ 25.99%
tinymce/CustomLoginPage.png4.05KB1.09KB▼ 73.04%
img/a5-icon-34.png1.65KB1.35KB▼ 18.07%
img/a5-icon-11.png0.67KB0.42KB▼ 37.17%