62% all-in-one-favicon

Code Review | All In One Favicon

WordPress plugin All In One Favicon scored62%from 54 tests.

About plugin

  • Plugin page: all-in-one-favicon
  • Plugin version: 4.8
  • PHP version: 7.4.16
  • WordPress compatibility: 2.8-6.2
  • WordPress version: 6.3.1
  • First release: May 6, 2010
  • Latest release: Aug 8, 2023
  • Number of updates: 133
  • Update frequency: every 36.4 days
  • Top authors: techotronic (90.98%)grimmdude (6.77%)marnietave (3.76%)

Code review

54 tests

User reviews

82 reviews

Install metrics

100,000+ active /1,414,456 total downloads


Plugin footprint 65% from 16 tests

Installer Passed 1 test

🔺 Critical test (weight: 50) | Checking the installer triggered no errors
Installer ran successfully

Server metrics [RAM: ▲0.13MB] [CPU: ▼5.54ms] Passed 4 tests

A check of server-side resources used by All In One Favicon
Server-side resource usage in normal parameters
PageMemory (MB)CPU Time (ms)
Home /3.58 ▲0.1144.74 ▲2.10
Dashboard /wp-admin3.44 ▲0.1453.67 ▼3.83
Posts /wp-admin/edit.php3.56 ▲0.2051.90 ▼0.33
Add New Post /wp-admin/post-new.php6.03 ▲0.1392.04 ▼19.72
Media Library /wp-admin/upload.php3.37 ▲0.1338.32 ▲1.74
Other Tools /wp-admin/admin.php?page=all-in-one-favicon-plugin-other-tools3.3334.52
AppSumo /wp-admin/admin.php?page=aiof_go_appsumo_pro3.2129.35
All in one Favicon /wp-admin/admin.php?page=all-in-one-favicon3.3536.33

Server storage [IO: ▲0.33MB] [DB: ▲0.00MB] Passed 3 tests

Analyzing filesystem and database footprints of this plugin
There were no storage issued detected upon installing this plugin
Filesystem: 71 new files
Database: no new tables, 6 new options
New WordPress options

Browser metrics Passed 4 tests

This is an overview of browser requirements for All In One Favicon
This plugin has a minimal impact on browser resources
PageNodesMemory (MB)Script (ms)Layout (ms)
Home /2,829 ▲4314.17 ▼0.391.72 ▼0.5233.07 ▼8.98
Dashboard /wp-admin2,237 ▲605.62 ▲0.0293.14 ▼13.9048.53 ▲4.82
Posts /wp-admin/edit.php2,139 ▲392.02 ▲0.0340.02 ▲3.9938.97 ▲2.26
Add New Post /wp-admin/post-new.php1,558 ▲3223.07 ▼0.07712.40 ▲44.4551.74 ▲3.67
Media Library /wp-admin/upload.php1,433 ▲304.12 ▼0.1199.94 ▼2.0149.16 ▲7.08
Other Tools /wp-admin/admin.php?page=all-in-one-favicon-plugin-other-tools1,0142.0424.6047.20
AppSumo /wp-admin/admin.php?page=aiof_go_appsumo_pro2,22115.10599.61172.34
All in one Favicon /wp-admin/admin.php?page=all-in-one-favicon1,4602.0423.6944.86

Uninstaller [IO: ▲0.00MB] [DB: ▲0.00MB] 50% from 4 tests

🔸 Tests weight: 35 | Verifying that this plugin uninstalls completely without leaving any traces
The following items require your attention
  • The plugin did not uninstall gracefully
    • > Deprecated in wp-includes/class-wp-hook.php+310
    Non-static method AllInOneFavicon::uninstallAioFavicon() should not be called statically
  • Zombie WordPress options detected upon uninstall: 6 options
    • widget_recent-comments
    • db_upgraded
    • can_compress_scripts
    • theysaidso_admin_options
    • widget_recent-posts
    • widget_theysaidso_widget

Smoke tests 25% from 4 tests

Server-side errors Passed 1 test

🔹 Test weight: 20 | A smoke test targeting server-side errors
Even though no errors were found, this is by no means an exhaustive test

SRP 0% from 2 tests

🔹 Tests weight: 20 | A shallow check of the single-responsibility principle; PHP files should perform no action - including output of placeholder text - and trigger no errors when accessed directly
Almost there! Just fix the following items
  • 3× PHP files output text when accessed directly:
    • > /wp-content/plugins/all-in-one-favicon/includes/appsumo-capture-form.php
    • > /wp-content/plugins/all-in-one-favicon/appsumo-capture-form.php
    • > /wp-content/plugins/all-in-one-favicon/includes/settings-page/sp-footer.php
  • 15× GET requests to PHP files have triggered server-side errors or warnings (only 10 are shown):
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_thickbox() in wp-content/plugins/all-in-one-favicon/appsumo.php:1
    • > PHP Fatal error
      Uncaught Error: Call to undefined function _e() in wp-content/plugins/all-in-one-favicon/includes/settings-page/sp-translation.php:14
    • > PHP Fatal error
      Uncaught Error: Call to undefined function plugin_basename() in wp-content/plugins/all-in-one-favicon/all-in-one-favicon.php:30
    • > PHP Fatal error
      Uncaught Error: Call to undefined function _e() in wp-content/plugins/all-in-one-favicon/includes/settings-page/sp-tipps-box.php:15
    • > PHP Fatal error
      Uncaught Error: Call to undefined function _e() in wp-content/plugins/all-in-one-favicon/includes/settings-page/sp-donations.php:14
    • > PHP Warning
      Use of undefined constant AIOFAVICON_NAME - assumed 'AIOFAVICON_NAME' (this will throw an Error in a future version of PHP) in wp-content/plugins/all-in-one-favicon/includes/settings-page.php on line 15
    • > PHP Fatal error
      Uncaught Error: Call to undefined function add_thickbox() in wp-content/plugins/all-in-one-favicon/other_tools.php:2
    • > PHP Fatal error
      Uncaught Error: Call to undefined function _e() in wp-content/plugins/all-in-one-favicon/includes/settings-page/sp-delete-settings.php:15
    • > PHP Fatal error
      Uncaught Error: Using $this when not in object context in wp-content/plugins/all-in-one-favicon/includes/settings-page/sp-plugin-favicon-settings.php:12
    • > PHP Fatal error
      Uncaught Error: Call to undefined function plugin_dir_path() in wp-content/plugins/all-in-one-favicon/includes/settings-page/sp-right-column.php:28

User-side errors 0% from 1 test

🔹 Test weight: 20 | Just a short smoke test targeting errors on the browser (console and network errors and warnings)
Please fix the following browser errors
    • > GET request to /wp-admin/admin.php?page=aiof_go_appsumo_pro
    • > Network (severe)
    https://appsumo.com/tools/wordpress/?utm_source=sumo&utm_medium=wp-widget&utm_campaign=all-in-one-favicon - Failed to load resource: the server responded with a status of 404 ()
    • > GET request to /wp-admin/admin.php?page=aiof_go_appsumo_pro
    • > Javascript (severe) in unknown
    https://appsumo2-cdn.appsumo.com/static/dist/js/vue_bridge.61ea1a9c.js 6:75186 Uncaught TypeError: (void 0) is not a function
    • > GET request to /wp-admin/admin.php?page=aiof_go_appsumo_pro
    • > Console-api (warning) in unknown
    https://accounts.google.com/gsi/client 41:457 "[GSI_LOGGER]: Relative login_uri was provided. Use absolute url instead. Relative login_uri may be considered invalid in the future."


Plugin configuration 93% from 29 tests

readme.txt 94% from 16 tests

You should put a lot of thought into formatting readme.txt as it is used by WordPress.org to prepare the public listing of your plugin
These attributes need your attention:
  • Tags: Too many tags (12 tag instead of maximum 10); only the first 5 tags are used in your directory listing
You can look at the official readme.txt

all-in-one-favicon/all-in-one-favicon.php 92% from 13 tests

"All In One Favicon" version 4.8's primary PHP file adds more information about the plugin and serves as the entry point for WordPress
Please take the time to fix the following:
  • Description: Please don't use more than 140 characters for the plugin description (currently 178 characters long)

Code Analysis Passed 3 tests

File types Passed 1 test

🔸 Test weight: 35 | This is an overview of file extensions present in this plugin and a short test that no dangerous files are bundled with this plugin
Good job! No executable or dangerous file extensions detected4,211 lines of code in 48 files:
LanguageFilesBlank linesComment linesLines of code
PO File178681,1692,696

PHP code Passed 2 tests

An overview of cyclomatic complexity and code structure
This plugin has no cyclomatic complexity problems
Cyclomatic complexity
Average complexity per logical line of code0.38
Average class complexity14.83
▷ Minimum class complexity3.00
▷ Maximum class complexity44.00
Average method complexity3.13
▷ Minimum method complexity1.00
▷ Maximum method complexity19.00
Code structure
▷ Abstract classes00.00%
▷ Concrete classes6100.00%
▷ Final classes00.00%
▷ Static methods00.00%
▷ Public methods39100.00%
▷ Protected methods00.00%
▷ Private methods00.00%
▷ Named functions1100.00%
▷ Anonymous functions00.00%
▷ Global constants13100.00%
▷ Class constants00.00%
▷ Public constants00.00%

Plugin size Passed 2 tests

Image compression Passed 2 tests

All PNG images should be compressed to minimize bandwidth usage for end users
2 PNG files occupy 0.01MB with 0.00MB in potential savings
Potential savings
Compression of 2 random PNG files using pngquant
FileSize - originalSize - compressedSavings
images/products/sumo-logo.png6.58KB3.19KB▼ 51.51%